Allow to specify a random seed independently of whether shuffling is requested

joshiayush · joshiayush · commit 3ea587050da9 · 2021-12-04T21:18:18.000+05:30
This commit fixes issue #3681 Signed-off-by: Ayush Joshi <ayush854032@gmail.com>
diff --git a/googletest/src/gtest.cc b/googletest/src/gtest.cc
@@ -5835,9 +5835,7 @@ bool UnitTestImpl::RunAllTests() {
     return true;
   }
 
-  random_seed_ = GTEST_FLAG_GET(shuffle)
-                     ? GetRandomSeedFromFlag(GTEST_FLAG_GET(random_seed))
-                     : 0;
+  random_seed_ = GetRandomSeedFromFlag(GTEST_FLAG_GET(random_seed));
 
   // True if and only if at least one test has failed.
   bool failed = false;

Original file line number	Diff line number	Diff line change
`@@ -5835,9 +5835,7 @@ bool UnitTestImpl::RunAllTests() {`
`5835`	`5835`	`return true;`
`5836`	`5836`	`}`
`5837`	`5837`
`5838`		`- random_seed_ = GTEST_FLAG_GET(shuffle)`
`5839`		`- ? GetRandomSeedFromFlag(GTEST_FLAG_GET(random_seed))`
`5840`		`- : 0;`
	`5838`	`+ random_seed_ = GetRandomSeedFromFlag(GTEST_FLAG_GET(random_seed));`
`5841`	`5839`
`5842`	`5840`	`// True if and only if at least one test has failed.`
`5843`	`5841`	`bool failed = false;`