Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
6e0d142 to
304839c
Compare
Author
ReplaceObsoletesStepRemoveUnusedDeclarations
3e2ecb4 to
83b6daa
Compare
Author
|
google seems dead. |
Contributor
|
@Pankraz76, for future reference, Google employees can't even look at your PR until you accept the CLA. |
Author
|
its signed:
Agreement Name Date Signed Manage |
Author
|
as every tweak encountered here is fixed in palantir, consider google dead and will drop accordingly: |
83b6daa to
6dfcb65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Add
RemoveUnusedDeclarationsformatting ruleThis PR introduces a new Java formatting rule that automatically removes redundant modifiers and declarations that are either:
Motivation
During codebase modernization efforts (#2524), we identified recurring patterns where:
publicin interfaces)final staticinstead ofstatic final)As highlighted in this comment, such redundancies:
Key Features
The rule handles:
Interface members:
public,static,final,abstractmodifierspublic static final int CONST→int CONSTNested types:
public static class Inner→static class InnerEnum declarations:
public static final VALUE→VALUEModern Java features:
public finalparams → implicit)Annotation declarations:
@interfaceformatting)Benefits
Reduced Noise:
Maintenance Efficiency:
Modern Java Support:
Non-intrusive:
Implementation Notes
privatewhen meaningful)@Nullable finalparametersIntegration
Works seamlessly with: