fix: Address modernize.omitzero issues (#3972)

Author: alexandear

.golangci.yml

@@ -92,9 +92,6 @@ linters:
       ignore-rules:
         - analyses # returned by the GitHub API
         - cancelled # returned by the GitHub API
-    modernize:
-      disable:
-        - omitzero # TODO: fix
     nolintlint:
       allow-unused: true
       require-specific: true

github/activity_notifications.go

@@ -101,10 +101,11 @@ func (s *ActivityService) ListRepositoryNotifications(ctx context.Context, owner
 }
 
 type markReadOptions struct {
-	LastReadAt Timestamp `json:"last_read_at,omitempty"`
+	LastReadAt Timestamp `json:"last_read_at,omitzero"`
 }
 
 // MarkNotificationsRead marks all notifications up to lastRead as read.
+// If lastRead is the zero value, all notifications in the repository are marked as read.
 //
 // GitHub API docs: https://docs.github.com/rest/activity/notifications#mark-notifications-as-read
 //
@@ -123,6 +124,7 @@ func (s *ActivityService) MarkNotificationsRead(ctx context.Context, lastRead Ti
 
 // MarkRepositoryNotificationsRead marks all notifications up to lastRead in
 // the specified repository as read.
+// If lastRead is the zero value, all notifications in the repository are marked as read.
 //
 // GitHub API docs: https://docs.github.com/rest/activity/notifications#mark-repository-notifications-as-read
 //

github/activity_notifications_test.go

@@ -117,6 +117,25 @@ func TestActivityService_MarkNotificationsRead(t *testing.T) {
 	})
 }
 
+func TestActivityService_MarkNotificationsRead_EmptyLastReadAt(t *testing.T) {
+	t.Parallel()
+	client, mux, _ := setup(t)
+
+	mux.HandleFunc("/notifications", func(w http.ResponseWriter, r *http.Request) {
+		testMethod(t, r, "PUT")
+		testHeader(t, r, "Content-Type", "application/json")
+		testBody(t, r, `{}`+"\n")
+
+		w.WriteHeader(http.StatusResetContent)
+	})
+
+	ctx := t.Context()
+	_, err := client.Activity.MarkNotificationsRead(ctx, Timestamp{})
+	if err != nil {
+		t.Errorf("Activity.MarkNotificationsRead returned error: %v", err)
+	}
+}
+
 func TestActivityService_MarkRepositoryNotificationsRead(t *testing.T) {
 	t.Parallel()
 	client, mux, _ := setup(t)
@@ -146,6 +165,25 @@ func TestActivityService_MarkRepositoryNotificationsRead(t *testing.T) {
 	})
 }
 
+func TestActivityService_MarkRepositoryNotificationsRead_EmptyLastReadAt(t *testing.T) {
+	t.Parallel()
+	client, mux, _ := setup(t)
+
+	mux.HandleFunc("/repos/o/r/notifications", func(w http.ResponseWriter, r *http.Request) {
+		testMethod(t, r, "PUT")
+		testHeader(t, r, "Content-Type", "application/json")
+		testBody(t, r, `{}`+"\n")
+
+		w.WriteHeader(http.StatusResetContent)
+	})
+
+	ctx := t.Context()
+	_, err := client.Activity.MarkRepositoryNotificationsRead(ctx, "o", "r", Timestamp{})
+	if err != nil {
+		t.Errorf("Activity.MarkRepositoryNotificationsRead returned error: %v", err)
+	}
+}
+
 func TestActivityService_GetThread(t *testing.T) {
 	t.Parallel()
 	client, mux, _ := setup(t)

github/repos_contents.go

@@ -48,7 +48,7 @@ type RepositoryContent struct {
 // RepositoryContentResponse holds the parsed response from CreateFile, UpdateFile, and DeleteFile.
 type RepositoryContentResponse struct {
 	Content *RepositoryContent `json:"content,omitempty"`
-	Commit  `json:"commit,omitempty"`
+	Commit  `json:"commit"`
 }
 
 // RepositoryContentFileOptions specifies optional parameters for CreateFile, UpdateFile, and DeleteFile.