Skip to content

Commit a9dac08

Browse files
committed
renderdiff: add transmission and ssao tests
- Add transmission and ssao tests - Small mods to README.md - Add transmission models to gltf list - Change focal length to zoom in for more details RDIFF_BRANCH=pf/renderdiff-add-transmission
1 parent 20fcce1 commit a9dac08

File tree

3 files changed

+45
-14
lines changed

3 files changed

+45
-14
lines changed

test/renderdiff/README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
# Rendering Difference Test
22

3-
We created a few scripts to run `gltf_viewer` and produce headless renderings.
3+
This tool is a collections of scripts to run `gltf_viewer` and produce headless renderings.
44

5-
This is mainly useful for continuous integration where GPUs are generally not available on cloud
5+
This is useful for continuous integration where GPUs are generally not available on cloud
66
machines. To perform software rasterization, these scripts are centered around [Mesa]'s software
77
rasterizers, but nothing bars us from using another rasterizer like [SwiftShader]. Additionally,
88
we should be able to use GPUs where available (though this is more of a future work).
99

1010
The script `render.py` contains the core logic for taking input parameters (such as the test
11-
description file) and then running gltf_viewer to produce the renderings.
11+
description file) and then running `gltf_viewer` to produce the renderings.
1212

13-
In the `test` directory is a list of test descriptions that are specified in json. Please see
14-
`sample.json` to parse the structure.
13+
The `test` directory contains a list of test descriptions that are specified in json. Please see
14+
`sample.json` to glean the structure.
1515

1616
## Setting up python
1717
The `renderdiff` project uses `python` extensively. To install the dependencies for producing
@@ -108,8 +108,8 @@ Doing the above has multiple effects:
108108

109109
## Viewing test results
110110
We provide a viewer for looking at the result of a test run. The viewer is a webapp that can be used by
111-
pointing your browser to a localhost port. If you input the viewer with a PR or a directory, it will
112-
parse the test result and show the results and the rendered and/or golden images.
111+
pointing your browser to a localhost port. If you provide the viewer with a PR or a directory, it will
112+
parse the test result json and show the results - which are rendered and golden images.
113113

114114
![Viewer](docs/images/renderdiff_example.png)
115115

test/renderdiff/tests/gltf_models.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
AlphaBlendModeTest
22
AttenuationTest
3-
Box
43
BoomBoxWithAxes
4+
Box
55
BoxInterleaved
66
BoxTextured
77
BoxTexturedNonPowerOfTwo
88
Duck
99
IridescenceSuzanne
10+
IridescentDishWithOlives
1011
Lantern
1112
MetalRoughSpheres
1213
NegativeScaleTest
@@ -17,4 +18,5 @@ Sponza
1718
Suzanne
1819
TextureCoordinateTest
1920
TextureSettingsTest
21+
TransmissionRoughnessTest
2022
TwoSidedPlane

test/renderdiff/tests/presubmit.json

Lines changed: 35 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,35 +5,64 @@
55
"presets": [
66
{
77
"name": "base",
8-
"models": ["Box", "BoxTextured", "Duck", "lucy", "FlightHelmet"],
8+
"models": ["Box", "BoxTextured", "FlightHelmet", "lucy"],
99
"rendering": {
10-
"viewer.cameraFocusDistance": 0,
10+
"viewer.cameraFocalLength": 35.0,
1111
"view.postProcessingEnabled": true,
1212
"view.dithering": "NONE"
1313
}
1414
},
1515
{
16-
"name": "helmet_only",
16+
"name": "bloom_models",
1717
"models": ["DamagedHelmet"],
1818
"rendering": {}
19+
},
20+
{
21+
"name": "ssao_models",
22+
"models": ["Duck", "lucy"],
23+
"rendering": {}
24+
},
25+
{
26+
"name": "transmission_models",
27+
"models": ["TransmissionRoughnessTest", "IridescentDishWithOlives"],
28+
"rendering": {}
1929
}
2030
],
2131
"tests": [
2232
{
2333
"name": "Bloom",
24-
"description": "Testing bloom",
25-
"apply_presets": ["base", "helmet_only"],
34+
"description": "Bloom",
35+
"apply_presets": ["base", "bloom_models"],
2636
"rendering": {
2737
"view.bloom.enabled": true
2838
}
2939
},
3040
{
3141
"name": "MSAA",
32-
"description": "Testing multisampling anti-aliasing",
42+
"description": "Multisampling anti-aliasing",
3343
"apply_presets": ["base"],
3444
"rendering": {
3545
"view.msaa.enabled": true
3646
}
47+
},
48+
{
49+
"name": "Transimssion",
50+
"description": "transmission",
51+
"apply_presets": ["base", "transmission_models"],
52+
"rendering": {
53+
"viewer.cameraFocalLength": 52.0,
54+
"view.msaa.enabled": true,
55+
"view.screenSpaceReflections.enabled": true
56+
}
57+
},
58+
{
59+
"name": "SSAO",
60+
"description": "Screen space ambient occulsion",
61+
"apply_presets": ["base", "ssao_models"],
62+
"rendering": {
63+
"view.msaa.enabled": true,
64+
"view.ssao.enabled": true
65+
}
3766
}
3867
]
3968
}

0 commit comments

Comments
 (0)