Tpkd day2 new telemetry name by terryterpt · Pull Request #436 · google/digitalbuildings

terryterpt · 2021-12-08T05:05:27Z

Added new point name for chiller, cooling tower and pump

…italbuildings into tpkd-day2-naming

tasodorff

Please provide feedback on the comments, certain usage is unclear.

ontology/yaml/resources/fields/telemetry_fields.yaml

tasodorff · 2021-12-08T20:02:13Z

ontology/yaml/resources/fields/telemetry_fields.yaml

+- compressor_power_sensor
+- refrigerant_open_percentage_sensor
+- standby_compressor_status
+- pump_speed_mode


i have changed to speed_mode, as this is referred to a component of a device which has states of MANUAL & AUTO.

tasodorff

Please provide some comments on the fields involving load. I am not following the meaning.

ontology/yaml/resources/fields/telemetry_fields.yaml

…nd other points

tasodorff

I have left a lot of comments; I am not convinced most of these points are needed, particularly alarms and the various valve open/closed points; are there not fields that tell us the position of the valve as OPEN/CLOSED?

If this is something we should discuss in a meeting, reach out; I would prefer to purge this list of anything that is unnecessary, and reduce the number of bespoke types and fields that will likely not be reused.

tasodorff · 2022-01-15T00:26:02Z

ontology/yaml/resources/HVAC/entity_types/CDWS.yaml

  - return_water_isolation_valve_status_4
+
+
+CDWS_TPKD:


if you remove condensing_water_ can most of this not be modeled with existing abstract types? It is fine if it is not canonical, but most of the fields on here can be covered by proper abstract types.

tasodorff · 2022-01-15T00:26:40Z

ontology/yaml/resources/HVAC/entity_types/CH.yaml

-  - run_mode
+  - run_mode
+
+CH_SS_TPKD:


Same comment as above. Is the only thing on here that can be modeled as an abstract type really SS?

ontology/yaml/resources/fields/telemetry_fields.yaml

tasodorff · 2022-01-28T03:52:30Z

ontology/yaml/resources/fields/telemetry_fields.yaml

+
+- motor_energy_sensor
+- motor_frequency_sensor
+- heat_percentage_sensor


what is the context for this?

heat_percentage_sensor - Motor Heat Load (Motor heat loss, calculated by output mechanical power from the input electrical power)

wouldnt this be in units of power then? something like heat_loss_thermal_power_sensor?

The unit is percent %

can the existing efficiency_percentage_sensor be used instead?

ontology/yaml/resources/fields/telemetry_fields.yaml

tasodorff · 2022-01-28T03:55:54Z

ontology/yaml/resources/fields/telemetry_fields.yaml

+- condensing_return_water_isolation_control_status:
+  - LOCAL
+  - REMOTE
+- condensing_return_water_isolation_closed_alarm:
+  - ACTIVE
+  - INACTIVE
+- condensing_return_water_isolation_open_alarm:
+  - ACTIVE
+  - INACTIVE
+- condensing_return_water_isolation_reset_alarm:
+  - ACTIVE
+  - INACTIVE
+- condensing_return_water_isolation_simulation_command:
+  - ON
+  - OFF
+- condensing_return_water_isolation_alarm:
+  - ACTIVE
+  - INACTIVE
+- condensing_supply_water_isolation_alarm:
+  - ACTIVE
+  - INACTIVE
+- condensing_supply_water_isolation_closed_alarm:
+  - ACTIVE
+  - INACTIVE
+- condensing_supply_water_isolation_open_alarm:
+  - ACTIVE
+  - INACTIVE
+- condensing_supply_water_isolation_reset_alarm:
+  - ACTIVE
+  - INACTIVE
+- open_command:
+  - ON
+  - OFF
+- condensing_supply_water_isolation_valve_run_command:
+  - ON
+  - OFF


i am not convinced any of these are needed; some are malformed; some seem unnecessary outside the BMS. what is the use case for them?

condensing_return_water_isolation_closed_alarm

condensing_return_water_isolation_open_alarm

condensing_return_water_isolation_reset_alarm

condensing_return_water_isolation_simulation_command

condensing_supply_water_isolation_closed_alarm

condensing_supply_water_isolation_open_alarm

condensing_supply_water_isolation_reset_alarm

condensing_return_water_isolation_alarm

condensing_supply_water_isolation_alarm

The points stated above are not necessary so they are removed. The rest of the points should stay as they are isolation value points that can be used to verify why chiller cannot run (if chiller is turned on by mistake)

There is also no such point name called "condensing_supply_water_isolation_valve_run_command", so it is removed as well

ontology/yaml/resources/fields/telemetry_fields.yaml

tasodorff · 2022-02-14T23:59:45Z

@Terry-Ter please see my comments regarding the different fields that look unnecessary. Can you please provide an update?

terryterpt · 2022-03-02T04:25:47Z

@tasodorff I have updated the pull request with the changes for the comments, please review it. Thank you!

tasodorff

More comments and clarifications required.

ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml

tasodorff · 2022-03-18T20:20:54Z

ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml

+  - condensing_water_isolation_valve_percentage_command
+  - condensing_water_isolation_valve_percentage_sensor
+
+PSMC:


Several questions here:

What kind of pump is this supposed to be? Is it a spray pump? A sweeper pump? Simply calling it pump isn't sufficient.

You have defined speed_mode, which implies its a speed (see here for an example). Looks like you really mean to use control_mode, so this needs to be changed.

You use speed_frequency_setpoint but I think you mean command.

If this is really just speed control for a thing, please follow precedent. See here for an example of how to model speed control.

In general, this appears to be something like VSC, which already exists. I don't know that this type is necessary. Can you please explain?

It is for the chill water pump
The pump_speed_mode is changing the mode between auto and manual, i will change to control mode
The pump_speed_frequency_setpoint is to the user input to set the 0-50Hz which is the speed of pump

you will model chilled water pumps on their own (they are not integral to a device, so you dont need to use the pump subfield. We know its on a pump because its the run command on a pump entity.

They type you are describing seems to be this. Please check and adjust.

The PSMC abstract type has been removed and the PMP types are updated

tasodorff · 2022-03-18T20:29:28Z

ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml

+  - pump_speed_mode
+  - pump_speed_frequency_setpoint
+
+CRWISVC:


CWRISOVM2X, to indicate it is actually two sets of valves.

CRWISVC has been changed to CWRISOVM2X

i dont see the changes reflected here. please make sure the PR is up to date.

Changes has been pushed to the PR

ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml

tasodorff · 2022-04-01T21:28:13Z

ontology/yaml/resources/HVAC/entity_types/PMP.yaml

+  - SS
+  - PSMC
+  - VSFC
+  - CHWISVPCM


same question as above -- they have automatic valves isolating individual pumps?

yes, the pump and the valve is inline

tasodorff · 2022-04-01T23:40:57Z

ontology/yaml/resources/HVAC/entity_types/TK.yaml

+########################
+
+TK_TPKD:
+  description: "Tpkd water tank."


Is this a single tank with three sets of alarms at different positions in the tank? If this were three separate tanks they should be modeled independently.

If this really is one tank, it is probably good to create an abstract type for this. How about something like this:

WLAM: description: "Water level alarm monitoring, generally for a water tank." is_abstract: true uses: - water_high_level_alarm - water_low_level_alarm - water_overflow_level_alarm WLAM3X: description: "Water level alarm monitoring, generally for a water tank with three independent sets of alarms." is_abstract: true uses: - water_high_level_alarm_1 - water_high_level_alarm_2 - water_high_level_alarm_3 - water_low_level_alarm_1 - water_low_level_alarm_2 - water_low_level_alarm_3 - water_overflow_level_alarm_1 - water_overflow_level_alarm_2 - water_overflow_level_alarm_3 TK_WLAM3X: description: "A water tank with three sets of alarms for high, low, and overflow alerting." implements: - TK - WLAM3X

The abstract type has been created

ontology/yaml/resources/fields/telemetry_fields.yaml

tasodorff · 2022-04-01T23:46:38Z

ontology/yaml/resources/fields/telemetry_fields.yaml

+
+- motor_energy_sensor
+- motor_frequency_sensor
+- heat_percentage_sensor


wouldnt this be in units of power then? something like heat_loss_thermal_power_sensor?

ontology/yaml/resources/fields/telemetry_fields.yaml

tasodorff · 2022-04-12T03:07:49Z

@Terry-Ter is there an update for this?

tasodorff · 2022-05-19T13:46:59Z

@Terry-Ter please advise on updates

terryterpt · 2022-05-27T03:05:53Z

heat_percentage_sensor unit is %

tasodorff

Gave partial review, but the PR is still not updated. Please update the PR (make sure your local changes are reflected here) and see the additional comments I've made. Once those are all complete, I will review again.

ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml

tasodorff · 2022-06-01T23:13:26Z

ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml

+  - condensing_water_isolation_valve_percentage_command
+  - condensing_water_isolation_valve_percentage_sensor
+
+PSMC:


you will model chilled water pumps on their own (they are not integral to a device, so you dont need to use the pump subfield. We know its on a pump because its the run command on a pump entity.

They type you are describing seems to be this. Please check and adjust.

tasodorff · 2022-06-01T23:14:08Z

ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml

+  - pump_speed_mode
+  - pump_speed_frequency_setpoint
+
+CRWISVC:


i dont see the changes reflected here. please make sure the PR is up to date.

ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml

tasodorff · 2022-06-01T23:17:35Z

ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml

+  - condensing_return_water_isolation_valve_command_2
+  - condensing_return_water_isolation_valve_status_1
+  - condensing_return_water_isolation_valve_status_2
+  - condensing_return_water_isolation_valve_mode


which valve though? you list two. which does it apply to?

tasodorff · 2022-06-01T23:18:08Z

ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml

+  - condensing_return_water_isolation_valve_status_2
+  - condensing_return_water_isolation_valve_mode
+
+CSWISVC:


the adjustments need to be made still. please ensure this PR is up to date with your local changes.

ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml

tasodorff · 2022-06-01T23:18:39Z

ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml

+  - condensing_supply_water_isolation_valve_command_2
+  - condensing_supply_water_isolation_valve_status_1
+  - condensing_supply_water_isolation_valve_status_2
+  - condensing_supply_water_isolation_valve_mode


unless you can designate which valve it belongs to, this should be removed.

it is used for both valves

charbull · 2022-11-07T15:34:08Z

@Terry-Ter @tasodorff any updates on this?
@mschulze17 fyi

terryterpt · 2023-03-10T08:11:07Z

Hi Trevor, I have updated the PR for your review, my apologizes on the late update.

shambersafai · 2024-10-24T15:49:44Z

@terryterpt are the changes in this PR still needed?

terryterpt · 2024-10-28T08:57:16Z

Hi @shambergoldstein , yes this PR is still needed

shambersafai · 2024-10-28T14:55:11Z

ontology/yaml/resources/fields/telemetry_fields.yaml

all fields must have states or value ranges, plese adjust accordingly

ontology/yaml/resources/fields/telemetry_fields.yaml

shambersafai · 2024-10-28T15:07:56Z

ontology/yaml/resources/fields/telemetry_fields.yaml

  - STANDBY
 - battery_charge_percentage_sensor
 - brightness_percentage_command
+- speed_mode:


field has since been added, please add to the states on the existing one as needed and remove this one from PR

ontology/yaml/resources/fields/telemetry_fields.yaml

shambersafai

Added some comments/requests. In general these files are pretty outdated due to how old the PR is. Please update the branch, resolving any conflicts with the existing files to date, and revisit the more recently added fields and types to see if they can be used in place of some of the ones you have added here.

shambersafai · 2024-10-28T15:24:13Z

ontology/yaml/resources/HVAC/entity_types/GENERALTYPES.yaml

TK already exists in the global namespace, please remove

shambersafai · 2024-10-28T15:25:28Z

ontology/yaml/resources/HVAC/entity_types/TK.yaml

TANK.yaml has since been added, please move this type there if needed and remove this file

shambersafai · 2024-10-28T15:28:09Z

ontology/yaml/resources/units/units.yaml

@@ -104,5 +106,7 @@ volume:
 - liters
 time:


these have since been added, please remove

shambersafai · 2024-10-28T15:29:00Z

ontology/yaml/resources/units/units.yaml

 - kilograms_per_hour
 frequency:
 - hertz: STANDARD
+- revolutions_per_minute


this exists under rotationalvelocity, please remove

shambersafai · 2024-10-28T15:29:53Z

ontology/yaml/resources/units/units.yaml

 - kilowatt_hours
 - megawatt_hours
 - therms
+- newton_meters


this exists under torque, please remove

shambersafai · 2024-10-28T16:14:40Z

ontology/yaml/resources/fields/telemetry_fields.yaml

 - position_status
 - condensing_water_valve_percentage_sensor
 - entering_cooling_coil_temperature_sensor
+- condensing_supply_water_isolation_valve_open_status


does the device have a singulary valve status that provides OPEN/CLOSED as its states that can be used in place of these?

shambersafai · 2024-10-28T16:15:41Z

ontology/yaml/resources/fields/telemetry_fields.yaml

+- condensing_supply_water_isolation_valve_closed_status
+- condensing_supply_water_isolation_valve_open_command
+- condensing_supply_water_isolation_valve_closed_command
+- entering_chilled_water_temperature_sensor


is this the same as chilled_return_water_temperature sensor?

shambersafai · 2024-10-28T16:15:52Z

ontology/yaml/resources/fields/telemetry_fields.yaml

+- condensing_supply_water_isolation_valve_open_command
+- condensing_supply_water_isolation_valve_closed_command
+- entering_chilled_water_temperature_sensor
+- leaving_chilled_water_temperature_sensor


is this the same as chilled_supply_water_temperature sensor?

shambersafai · 2024-10-28T16:16:21Z

ontology/yaml/resources/fields/telemetry_fields.yaml

+- condensing_supply_water_isolation_valve_closed_command
+- entering_chilled_water_temperature_sensor
+- leaving_chilled_water_temperature_sensor
+- compressor_percentage_sensor


compressor_speed_percentage_sensor already exists, please remove

shambersafai · 2024-10-28T16:21:33Z

ontology/yaml/resources/fields/telemetry_fields.yaml

  - ABSENT

+# Added for TPKD day2
+- condensing_supply_water_isolation_valve_mode:


Are these points necessary to bring in? We should be able to tell from the command and status if the valve is in manual override.

conroychee and others added 7 commits November 29, 2021 09:51

added new points for tpkd day2 work

c38dd3d

Merge branch 'master' into tpkd-day2-naming

f922599

revert back to original master changes

5e1ad20

Merge branch 'google:master' into tpkd-day2-naming

de00fed

changed the description for motor and oil

4013a5d

Merge branch 'tpkd-day2-naming' of https://github.com/conroy-chee/dig…

3a66457

…italbuildings into tpkd-day2-naming

added new telemetry field point name

bfac976

tasodorff requested changes Dec 8, 2021

View reviewed changes

changes according to the comment

292388a

tasodorff reviewed Jan 4, 2022

View reviewed changes

ontology/yaml/resources/fields/telemetry_fields.yaml Outdated Show resolved Hide resolved

ontology/yaml/resources/fields/telemetry_fields.yaml Outdated Show resolved Hide resolved

ontology/yaml/resources/fields/telemetry_fields.yaml Outdated Show resolved Hide resolved

conroychee and others added 4 commits January 5, 2022 12:34

changed the definition of load, added compressor_temperature_sensor a…

bc6f5be

…nd other points

Merge branch 'google:master' into tpkd-day2-new-telemetry-name

79c02be

added everything for day2 tpkd

e291099

Merge branch 'master' into tpkd-day2-new-telemetry-name

8398380

tasodorff requested changes Jan 28, 2022

View reviewed changes

update pull request

907e9a7

tasodorff requested changes Apr 1, 2022

View reviewed changes

mschulze17 added info requested from creator Waiting on PR creator to respond to request for further info and removed info requested from creator Waiting on PR creator to respond to request for further info labels May 24, 2022

tasodorff requested changes Jun 1, 2022

View reviewed changes

mschulze17 assigned terryterpt Jun 2, 2022

update tpkd day 2 types

0e393a6

cstirdivant added the Ontology Model Extensions or edits to the ontology model label Jan 12, 2024

shambersafai reviewed Oct 28, 2024

View reviewed changes

shambersafai requested changes Oct 28, 2024

View reviewed changes

		- return_water_isolation_valve_status_4


		CDWS_TPKD:

Comments

Conversation

terryterpt commented Dec 8, 2021

Uh oh!

tasodorff left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tasodorff left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tasodorff left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

terryterpt Feb 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tasodorff commented Feb 14, 2022

Uh oh!

terryterpt commented Mar 2, 2022

Uh oh!

tasodorff left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

terryterpt Feb 15, 2022 •

edited

Loading