Remove support for Python 2 fuzzers. #1949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
inferno-chromium
requested changes
Aug 4, 2020
|
/gcbrun |
inferno-chromium
approved these changes
Aug 4, 2020
|
Nice! Can't think of any other Python 2 dependencies. We can try go ahead with removing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL. There are a few minor breakages left which I'll try to resolve (3 minor issues with external fuzzers), but overall I don't think it's worth keeping Python 2 around for them. After this lands there are no remaining Python 2 dependencies on bots that I know of.
Oliver, are there any other Python 2 dependencies you can think of? I don't think it's urgent that we remove Python 2 from the images, but it should be safe to do so after this.