Skip to content

Commit 449dff9

Browse files
jnthntatumcopybara-github
authored andcommitted
Address a few compiler warnings for clang.
- unused declarations (in implementation / test files) - 'struct' usage when referring to a class PiperOrigin-RevId: 791742127
1 parent 1e97c3c commit 449dff9

File tree

6 files changed

+4
-19
lines changed

6 files changed

+4
-19
lines changed

checker/standard_library.cc

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -103,18 +103,6 @@ Type TypeBytesType() {
103103
return *kInstance;
104104
}
105105

106-
Type TypeDurationType() {
107-
static absl::NoDestructor<Type> kInstance(
108-
TypeType(BuiltinsArena(), DurationType()));
109-
return *kInstance;
110-
}
111-
112-
Type TypeTimestampType() {
113-
static absl::NoDestructor<Type> kInstance(
114-
TypeType(BuiltinsArena(), TimestampType()));
115-
return *kInstance;
116-
}
117-
118106
Type TypeDynType() {
119107
static absl::NoDestructor<Type> kInstance(
120108
TypeType(BuiltinsArena(), DynType()));

common/values/custom_list_value_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ using ::testing::Optional;
5454
using ::testing::Pair;
5555
using ::testing::UnorderedElementsAre;
5656

57-
struct CustomListValueTest;
57+
class CustomListValueTest;
5858

5959
struct CustomListValueTestContent {
6060
google::protobuf::Arena* absl_nonnull arena;

common/values/custom_map_value_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ using ::testing::Optional;
5656
using ::testing::Pair;
5757
using ::testing::UnorderedElementsAre;
5858

59-
struct CustomMapValueTest;
59+
class CustomMapValueTest;
6060

6161
struct CustomMapValueTestContent {
6262
google::protobuf::Arena* absl_nonnull arena;

common/values/custom_struct_value_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ using ::testing::NotNull;
5555
using ::testing::Pair;
5656
using ::testing::UnorderedElementsAre;
5757

58-
struct CustomStructValueTest;
58+
class CustomStructValueTest;
5959

6060
struct CustomStructValueTestContent {
6161
google::protobuf::Arena* absl_nonnull arena;

eval/eval/logic_step_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ class LogicStepTest : public testing::TestWithParam<bool> {
104104
}
105105

106106
private:
107-
absl_nonnull std::shared_ptr<class RuntimeEnv> env_;
107+
absl_nonnull std::shared_ptr<const RuntimeEnv> env_;
108108
Arena arena_;
109109
};
110110

internal/number_test.cc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,6 @@
2222
namespace cel::internal {
2323
namespace {
2424

25-
constexpr double kNan = std::numeric_limits<double>::quiet_NaN();
26-
constexpr double kInfinity = std::numeric_limits<double>::infinity();
27-
2825
TEST(Number, Basic) {
2926
EXPECT_GT(Number(1.1), Number::FromInt64(1));
3027
EXPECT_LT(Number::FromUint64(1), Number(1.1));

0 commit comments

Comments
 (0)