Skip to content

Make all links relative. #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2015
Merged

Make all links relative. #680

merged 1 commit into from
May 5, 2015

Conversation

vmarmol
Copy link
Contributor

@vmarmol vmarmol commented May 5, 2015

This will allow cAdvisor to be reverse proxied, and fixes a long-standing feature request :)

Fixes #513
Fixes #566
Fixes #596
Fixes #667

This will allow cAdvisor to be reverse proxied.

Fixes google#513
Fixes google#566
Fixes google#596
Fixes google#667
@vmarmol
Copy link
Contributor Author

vmarmol commented May 5, 2015

/cc @rjnagal

@rjnagal
Copy link
Contributor

rjnagal commented May 5, 2015

LGTM

rjnagal added a commit that referenced this pull request May 5, 2015
@rjnagal rjnagal merged commit 4c21290 into google:master May 5, 2015
@schmichri
Copy link

schmichri commented Jan 9, 2017

+1
I don't understand it. I can see it in your codings but it's not document and I have the feeling it's not working at all.
IMHO must have for production environment.

@AnthonyWC
Copy link

Re: #667

I tested (via https://x.x.x.x/cadvisor/):

    location /cadvisor/ {
      proxy_pass         http://prometheus_cadvisor_1:8080/;
      proxy_set_header   Host $host;
      proxy_set_header   X-Forwarded-For $remote_addr;
    }

Results in 404 but this work

    location / {
      proxy_pass         http://prometheus_cadvisor_1:8080/;
      proxy_set_header   Host $host;
      proxy_set_header   X-Forwarded-For $remote_addr;
    }

So issue still exists as they reverted the change earlier and never fix it.

I can manually specify the url path, like this:

    location / {
      proxy_pass         http://prometheus_cadvisor_1:8080/containers/;
      proxy_set_header   Host $host;
      proxy_set_header   X-Forwarded-For $remote_addr;
    }

It doesn't display properly but doesn't show 404 error, and any non /containers/ links will break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants