Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process BTRFS and whole-disk filesystem stats #444

Merged
merged 1 commit into from
Feb 6, 2015

Conversation

arkadijs
Copy link
Contributor

XFS users might complain, but we - Docker users - use BTRFS. :)
Typical usage of CoreOS (on AWS) is to format whole device to BTRFS and mount it on /var/lib/docker, thus whole-disk stats must also be collected.

@vishh
Copy link
Contributor

vishh commented Jan 16, 2015

"TestGetDiskStatsMap" unit test is failing. Can you address the issue?

@arkadijs
Copy link
Contributor Author

Sorry for that, fixed.
I can force-push as a single commit if necessary.

@vmarmol
Copy link
Contributor

vmarmol commented Jan 16, 2015

LGTM, yes please. One commit would be nice :)

@arkadijs
Copy link
Contributor Author

Also added device-mapper to regex. Works for BTRFS volumes on LVM as they appears as /dev/dm-* in /proc/mounts even if mounted as /dev/vg/lv.
Not a complete solution because ext4 on LVM appears as intended, ie. /dev/vg/lv and thus does not match /proc/diskstats. No idea why such difference.

@arkadijs
Copy link
Contributor Author

I checked it on Docker host running with devicemapper storage driver. It doesn't help to collect the stats, but not making this worse either:

{
  "device": "/dev/mapper/docker-202:1-922914-e6128e016bdac12e73c36d70659e4984159878c3c33e1e3b962891185aaeb525",
  "capacity": 10434662400,
  "usage": 651108352,
  "reads_completed": 0,
  "reads_merged": 0,
  "sectors_read": 0,
  "read_time": 0,
  "writes_completed": 0,
  "writes_merged": 0,
  "sectors_written": 0,
  "write_time": 0,
  "io_in_progress": 0,
  "io_time": 0,
  "weighted_io_time": 0
},

@vishh
Copy link
Contributor

vishh commented Jan 27, 2015

LGTM. @vmarmol any other comments?

@cadvisorJenkinsBot
Copy link
Collaborator

Can one of the admins verify this patch?

@vmarmol
Copy link
Contributor

vmarmol commented Feb 6, 2015

LGTM

vmarmol added a commit that referenced this pull request Feb 6, 2015
Process BTRFS and whole-disk filesystem stats
@vmarmol vmarmol merged commit f2efed3 into google:master Feb 6, 2015
@arkadijs arkadijs deleted the btrfs branch February 10, 2015 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants