-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process BTRFS and whole-disk filesystem stats #444
Conversation
"TestGetDiskStatsMap" unit test is failing. Can you address the issue? |
Sorry for that, fixed. |
LGTM, yes please. One commit would be nice :) |
Also added device-mapper to regex. Works for BTRFS volumes on LVM as they appears as /dev/dm-* in /proc/mounts even if mounted as /dev/vg/lv. |
I checked it on Docker host running with devicemapper storage driver. It doesn't help to collect the stats, but not making this worse either:
|
LGTM. @vmarmol any other comments? |
Can one of the admins verify this patch? |
LGTM |
Process BTRFS and whole-disk filesystem stats
XFS users might complain, but we - Docker users - use BTRFS. :)
Typical usage of CoreOS (on AWS) is to format whole device to BTRFS and mount it on /var/lib/docker, thus whole-disk stats must also be collected.