collector: restrict appmetrics endpoint to container ip#3843
Open
1seal wants to merge 1 commit intogoogle:masterfrom
Open
collector: restrict appmetrics endpoint to container ip#38431seal wants to merge 1 commit intogoogle:masterfrom
1seal wants to merge 1 commit intogoogle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
appmetrics: restrict endpoint url to container-local
this hardens application metrics scraping against workload-controlled config (for example, docker labels
io.cadvisor.metric.*) turning cAdvisor into a cross-network fetcher.change
localhost/127.0.0.1/::1, rewrite it to the container ip from the container handlerdocs/application_metrics.mdcompatibility
this is a behavior change for configs that pointed
endpointat remote hosts.docs/application_metrics.mdalready describes the config as self-contained within the container; this change makes the implementation match that model.testing