add docker_only_prefix_whitelist flag and fix issue #2129 #2164
Conversation
|
Hi @viberan. Thanks for your PR. I'm waiting for a google or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
cadvisor.go
Outdated
| @@ -65,6 +65,8 @@ var whitelistedContainerLabels = flag.String("whitelisted_container_labels", "", | |||
|
|
|||
| var urlBasePrefix = flag.String("url_base_prefix", "", "prefix path that will be prepended to all paths to support some reverse proxies") | |||
|
|
|||
| var dockerOnlyPrefixWhiteList = flag.String("docker_only_prefix_whitelist", "", "A comma-separated list of cgroup path prefix that needs to be collected even when docker-only is specified") | |||
There was a problem hiding this comment.
i'm not a particular fan of the naming for the docker_only flag, since it is runtime-specific. Can we call it raw_cgroup_roots or something? We can make it clear in the comment that setting it causes those cgroups to be collected even when --docker-only is specified since comments don't have backwards compatibility guarantees
There was a problem hiding this comment.
@dashpole would raw_cgroup_prefix_whitelist be a better fit?
There was a problem hiding this comment.
that would be fine as well
|
looks good, please squash |
|
@dashpole done |
No description provided.