Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodically updates machine info #2147

Merged
merged 2 commits into from
Jan 16, 2019

Conversation

namreg
Copy link
Contributor

@namreg namreg commented Jan 15, 2019

Proposal to resolve #2146

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@k8s-ci-robot
Copy link
Collaborator

Hi @namreg. Thanks for your PR.

I'm waiting for a google or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@namreg
Copy link
Contributor Author

namreg commented Jan 15, 2019

I signed it

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@namreg namreg force-pushed the update-machine-info-periodically branch from 1b6b809 to 8b0ff01 Compare January 15, 2019 15:17
@dashpole
Copy link
Collaborator

/ok-to-test

Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@dashpole
Copy link
Collaborator

/ok-to-test

@dashpole
Copy link
Collaborator

I0115 19:49:44.116] >> checking go formatting
I0115 19:49:44.669] The following files are not properly formatted:
I0115 19:49:44.669] manager/manager.go

@namreg
Copy link
Contributor Author

namreg commented Jan 15, 2019

/retest

@namreg
Copy link
Contributor Author

namreg commented Jan 16, 2019

@dashpole fixed

@dashpole dashpole merged commit 150629c into google:master Jan 16, 2019
@namreg namreg deleted the update-machine-info-periodically branch January 17, 2019 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates machine info periodically
4 participants