Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether Mesos task labels are available #2122

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Check whether Mesos task labels are available #2122

merged 1 commit into from
Dec 5, 2018

Conversation

changlan
Copy link

@changlan changlan commented Dec 4, 2018

This patch fixes the panic issue when mesos.Task does not have a Labels reference:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xded5e4]

goroutine 1 [running]:
github.com/google/cadvisor/container/mesos.(*state).fetchLabelsFromTask(0xc000a0b378, 0xc000988270, 0x30, 0xc000980ae0, 0xc00087c1b8, 0x0)
        /home/lanchang/go/src/github.com/google/cadvisor/container/mesos/mesos_agent.go:116 +0xf4
github.com/google/cadvisor/container/mesos.(*state).FetchLabels(0xc000a0b378, 0xc000988240, 0x29, 0xc000988270, 0x30, 0x4, 0x4, 0xc000a0b388)
        /home/lanchang/go/src/github.com/google/cadvisor/container/mesos/mesos_agent.go:141 +0x3dd
github.com/google/cadvisor/container/mesos.(*client).getLabels(0xc00000e2b8, 0xc00097e4c0, 0x24, 0xc00097e4c0, 0x0)
        /home/lanchang/go/src/github.com/google/cadvisor/container/mesos/client.go:181 +0x175
github.com/google/cadvisor/container/mesos.(*client).ContainerInfo(0xc00000e2b8, 0xc0007c710d, 0x24, 0x24, 0x40c888, 0x10)
        /home/lanchang/go/src/github.com/google/cadvisor/container/mesos/client.go:89 +0x73
github.com/google/cadvisor/container/mesos.(*mesosFactory).CanHandleAndAccept(0xc000142780, 0xc0007c7100, 0x31, 0xc000a0b530, 0x2, 0x2)
        /home/lanchang/go/src/github.com/google/cadvisor/container/mesos/factory.go:110 +0x8a
github.com/google/cadvisor/container.NewContainerHandler(0xc0007c7100, 0x31, 0x0, 0x1e55101, 0x0, 0x0, 0x0, 0x0, 0x0)
        /home/lanchang/go/src/github.com/google/cadvisor/container/factory.go:107 +0x124
github.com/google/cadvisor/manager.(*manager).createContainerLocked(0xc0005101e0, 0xc0007c7100, 0x31, 0x0, 0x0, 0x0)
        /home/lanchang/go/src/github.com/google/cadvisor/manager/manager.go:965 +0xd6
github.com/google/cadvisor/manager.(*manager).createContainer(0xc0005101e0, 0xc0007c7100, 0x31, 0x0, 0x0, 0x0)
        /home/lanchang/go/src/github.com/google/cadvisor/manager/manager.go:952 +0x94
github.com/google/cadvisor/manager.(*manager).detectSubcontainers(0xc0005101e0, 0x11b9325, 0x1, 0x0, 0x0)
        /home/lanchang/go/src/github.com/google/cadvisor/manager/manager.go:1145 +0x199
github.com/google/cadvisor/manager.(*manager).Start(0xc0005101e0, 0xc0005bd170, 0x133f180)
        /home/lanchang/go/src/github.com/google/cadvisor/manager/manager.go:366 +0x50e
main.main()
        /home/lanchang/go/src/cadvisor/cadvisor.go:173 +0x4b6

@k8s-ci-robot
Copy link
Collaborator

Hi @changlan. Thanks for your PR.

I'm waiting for a google or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dashpole
Copy link
Collaborator

dashpole commented Dec 4, 2018

/ok-to-test

Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole
Copy link
Collaborator

dashpole commented Dec 4, 2018

container/mesos/mesos_agent.go:43:43: undefined: mesos

@changlan
Copy link
Author

changlan commented Dec 4, 2018

/retest

@changlan
Copy link
Author

changlan commented Dec 5, 2018

@dashpole Fixed.

@dashpole dashpole merged commit ba5704f into google:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants