added googletest dependency to tests (allows compilation with -j) #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch! Have you checked the contributing documentation? You should at least have signed the CFA before we can merge the patch. |
|
Does benchmark_test need the CMake dependency? It doesn't link against/include any Google Test libraries. |
|
probably not :-).. in that case "add_dependencies(re_test googletest)" is sufficient... |
|
@niklashofmann can you make the change to only include it for re_test? |
|
Why did you remove the extra compiler flag? |
|
because it does not compile otherwise |
|
@niklashofmann Could you open an issue with the compile error and platform information? I haven't seen an issue with it compiling before. |
dmah42
pushed a commit
that referenced
this pull request
Nov 1, 2014
added googletest dependency to tests (allows compilation with -j)
|
turns out we do want googletest in benchmark_test so the CHECK macros can be removed from the public API. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.