Skip to content

Commit 6b764fe

Browse files
committed
Fix Clang Detection
For several versions now, CMake by default refers to macOS’ Clang as AppleClang instead of just Clang, which would fail STREQUAL. Fixed by changing it to MATCHES.
1 parent a8082de commit 6b764fe

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

CMakeLists.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ else()
193193
if (GCC_RANLIB)
194194
set(CMAKE_RANLIB ${GCC_RANLIB})
195195
endif()
196-
elseif("${CMAKE_C_COMPILER_ID}" STREQUAL "Clang")
196+
elseif("${CMAKE_C_COMPILER_ID}" MATCHES "Clang")
197197
include(llvm-toolchain)
198198
endif()
199199
endif()
@@ -218,7 +218,7 @@ else()
218218
endif()
219219

220220
if (BENCHMARK_USE_LIBCXX)
221-
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
221+
if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
222222
add_cxx_compiler_flag(-stdlib=libc++)
223223
elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU" OR
224224
"${CMAKE_CXX_COMPILER_ID}" STREQUAL "Intel")

cmake/HandleGTest.cmake

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ macro(build_external_gtest)
55
include(ExternalProject)
66
set(GTEST_FLAGS "")
77
if (BENCHMARK_USE_LIBCXX)
8-
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
8+
if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
99
list(APPEND GTEST_FLAGS -stdlib=libc++)
1010
else()
1111
message(WARNING "Unsupported compiler (${CMAKE_CXX_COMPILER}) when using libc++")

0 commit comments

Comments
 (0)