add gocyclo and godot linters plus associated fixes

Author: adamvduke

.golangci.yml

@@ -28,6 +28,8 @@ linters:
     - gci
     - goconst
     - gocritic
+    - gocyclo
+    - godot
     - gofmt
     - goheader
     - gosec
@@ -93,6 +95,33 @@ linters-settings:
     exclude-functions:
       - (*bytes.Buffer).WriteString # WriteString is documented as always returning a nil error
 
+  gocyclo:
+    # Minimal code complexity to report.
+    # Default: 30
+    min-complexity: 10
+
+  godot:
+    # Comments to be checked: `declarations`, `toplevel`, or `all`.
+    # Default: declarations
+    scope: toplevel
+    # List of regexps for excluding particular comment lines from check.
+    # Default: []
+    exclude:
+      # Exclude todo and fixme comments.
+      - "^fixme:"
+      - "^todo:"
+      - "601"
+      - "Config-Item:"
+      - "Message:"
+      - "Last-Modified:"
+      - "URI:"
+    # Check that each sentence ends with a period.
+    # Default: true
+    period: true
+    # Check that each sentence starts with a capital letter.
+    # Default: false
+    capital: true
+
   gci:
     sections:
       - standard # Standard section: captures all standard packages.

message/message.go

@@ -167,8 +167,8 @@ func parseFields(lines []string) []*Field {
 func parseField(line string) *Field {
 	tokens := strings.Split(strings.TrimSpace(line), ":")
 
-	// the line may have additional colons, so the value needs to be any tokens
-	// after the first joined with a colon
+	// The line may have additional colons, so the value needs to be any tokens
+	// after the first joined with a colon.
 	valueTkns := make([]string, len(tokens[1:]))
 	for idx, valueTkn := range tokens[1:] {
 		valueTkns[idx] = strings.TrimSpace(valueTkn)

method/method.go

@@ -226,7 +226,7 @@ func (m *Method) waitForConfiguration() {
 	}
 }
 
-// A objectLocation wraps details about the requested items location in S3
+// A objectLocation wraps details about the requested items location in S3.
 type objectLocation struct {
 	uri    *url.URL
 	bucket string
@@ -241,15 +241,15 @@ func newLocation(value, s3Hostname string) (objectLocation, error) {
 	if uri.Host == s3Hostname {
 		tokens := strings.Split(uri.Path, "/")
 
-		// splitting "/bucket/this/is/a/path" on "/" produces
+		// Splitting "/bucket/this/is/a/path" on "/" produces
 		// ["", "bucket", "this", "is", "a", "path"]
 		// Note the initial empty string
 		if len(tokens) < 3 {
 			return objectLocation{}, errLocMissingRequiredTokens
 		}
 
-		// the first non-zero length string is assumed to be the bucket. the rest are
-		// concatenated back together as the path to the object in the bucket
+		// The first non-zero length string is assumed to be the bucket. The rest are
+		// concatenated back together as the path to the object in the bucket.
 		return objectLocation{
 			uri:    uri,
 			bucket: tokens[1],
@@ -272,7 +272,7 @@ func newLocation(value, s3Hostname string) (objectLocation, error) {
 	}, nil
 }
 
-// replace any forward slashes in access key and secret
+// Replace any forward slashes in access key and secret.
 func preProcessURL(url string) string {
 	idx := strings.Index(url, "@")
 	if idx < 0 {

method/method_test.go

@@ -27,7 +27,7 @@ Pipeline: true
 Single-Instance: yes
 `
 
-	// The trailing blank line is intentional
+	// The trailing blank line is intentional.
 	acqMsg = `600 URI Acquire
 URI: s3://fake-access-key-id:fake-access-key-secret@s3.amazonaws.com/apt-repo-bucket/apt/generic/python-bernhard_0.2.3-1_all.deb
 Filename: /tmp/python-bernhard_0.2.3-1_all.deb
@@ -38,7 +38,7 @@ Filename: /tmp/riemann-sumd_0.7.2-1_all.deb
 
 `
 
-	// The trailing blank line is intentional
+	// The trailing blank line is intentional.
 	configMsg = `601 Configuration
 Config-Item: Dir::Log=var/log/apt
 Config-Item: Dir::Log::Terminal=term.log