Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configurable emulator screen resolution #225

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jnhyperion
Copy link

Added emulator screen resolution configuration options in interactive mode.

image

Copy link
Collaborator

@pokowaka pokowaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Would you mind moving the UI pieces to emu_downloads_menu.py?
  • Would it be useful to have a set of default devices? (Pixel2, Pixel3, etc?) right now we have no way of specifying width/height/dpi from commandline.

@jnhyperion
Copy link
Author

  • Would you mind moving the UI pieces to emu_downloads_menu.py?
    OK.
  • Would it be useful to have a set of default devices? (Pixel2, Pixel3, etc?) right now we have no way of specifying width/height/dpi from commandline.

I thought about it before, there are 2 reasons why I prefer to enter width/height/dpi from command line:

  1. user could have some requests of customized devices, they have various width/height/dpi, we can not list all the hardware profile
  2. Pixel2 is hard coded in many code pieces, make it a variable will have many modifications

What do you think?

@pokowaka
Copy link
Collaborator

  • Would you mind moving the UI pieces to emu_downloads_menu.py?
    OK.
  • Would it be useful to have a set of default devices? (Pixel2, Pixel3, etc?) right now we have no way of specifying width/height/dpi from commandline.

I thought about it before, there are 2 reasons why I prefer to enter width/height/dpi from command line:

  1. user could have some requests of customized devices, they have various width/height/dpi, we can not list all the hardware profile
  2. Pixel2 is hard coded in many code pieces, make it a variable will have many modifications

What do you think?

You are absolutely right. I should have prefixed it with would you like us to make those changes (different device profiles)

@jnhyperion
Copy link
Author

@pokowaka sure, it would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants