Skip to content

Commit 06f4fde

Browse files
kvmiloscopybara-github
authored andcommitted
chore: remove internal references from exported files
PiperOrigin-RevId: 988094764
1 parent 849e1f6 commit 06f4fde

26 files changed

Lines changed: 10 additions & 70 deletions

File tree

‎a2a/src/main/java/com/google/adk/a2a/agent/RemoteA2AAgent.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -317,8 +317,6 @@ synchronized void handleError(String message, Throwable e) {
317317
emitter.tryOnError(new A2AClientError(message, e));
318318
}
319319

320-
// TODO: b/483038527 - The synchronized block might block the thread, we should optimize for
321-
// performance in the future.
322320
synchronized void handleEvent(ClientEvent clientEvent, AgentCard unused) {
323321
// Mark the flow as done if it is already cancelled.
324322
if (!done) {

‎contrib/spring-ai/src/test/java/com/google/adk/models/springai/MessageConverterTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -818,7 +818,7 @@ public Optional<FunctionDeclaration> declaration() {
818818

819819
@Test
820820
void testToolOptionsPreserveProviderSpecificTypeToAvoidClassCastException() {
821-
// Regression test for b/527041291 (GitHub adk-java #1295): Spring AI OpenAI 2.0.0 casts
821+
// Regression test for GitHub adk-java #1295: Spring AI OpenAI 2.0.0 casts
822822
// Prompt.getOptions() directly to OpenAiChatOptions in createRequest(). When ADK passed a
823823
// provider-neutral DefaultToolCallingChatOptions, that cast threw a ClassCastException. Basing
824824
// the prompt options on the model's own options must keep the concrete provider type.

‎core/src/main/java/com/google/adk/agents/LlmAgent.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ public Builder disallowTransferToPeers(boolean disallowTransferToPeers) {
282282
return this;
283283
}
284284

285-
// (b/476510024): Temporary workaround for ces
285+
/** Removes any before-model callbacks set on this builder. */
286286
@CanIgnoreReturnValue
287287
public Builder clearBeforeModelCallbacks() {
288288
this.beforeModelCallback = null;

‎core/src/main/java/com/google/adk/agents/LoopAgent.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ public Builder maxIterations(@Nullable Integer maxIterations) {
9999

100100
@Override
101101
public LoopAgent build() {
102-
// TODO(b/410859954): Add validation for required fields like name.
103102
return new LoopAgent(
104103
name, description, subAgents, maxIterations, beforeAgentCallback, afterAgentCallback);
105104
}

‎core/src/main/java/com/google/adk/agents/SequentialAgent.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ public static class Builder extends BaseAgent.Builder<Builder> {
8080

8181
@Override
8282
public SequentialAgent build() {
83-
// TODO(b/410859954): Add validation for required fields like name.
8483
return new SequentialAgent(
8584
name, description, subAgents, beforeAgentCallback, afterAgentCallback);
8685
}

‎core/src/main/java/com/google/adk/events/Event.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,6 @@
4242
import java.util.UUID;
4343
import org.jspecify.annotations.Nullable;
4444

45-
// TODO - b/413761119 update Agent.java when resolved.
46-
4745
/** Represents an event in a session. */
4846
@JsonDeserialize(builder = Event.Builder.class)
4947
public class Event extends JsonBaseModel {

‎core/src/main/java/com/google/adk/events/EventActions.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import org.jspecify.annotations.Nullable;
3232

3333
/** Represents the actions attached to an event. */
34-
// TODO - b/414081262 make json wire camelCase
3534
@JsonDeserialize(builder = EventActions.Builder.class)
3635
public class EventActions extends JsonBaseModel {
3736

‎core/src/main/java/com/google/adk/flows/llmflows/Contents.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -521,8 +521,6 @@ private static List<Event> rearrangeEventsForLatestFunctionResponse(List<Event>
521521
return events;
522522
}
523523

524-
// TODO: b/412663475 - Handle parallel function calls within the same event. Currently, this
525-
// throws an error.
526524
if (events.isEmpty() || Iterables.getLast(events).functionResponses().isEmpty()) {
527525
// No need to process if the list is empty or the last event is not a function response
528526
return events;

‎core/src/main/java/com/google/adk/flows/llmflows/Functions.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,6 @@ public static void populateClientFunctionCallId(Event modelResponseEvent) {
130130
}
131131
}
132132

133-
// TODO - b/413761119 add the remaining methods for function call id.
134-
135133
/** Handles standard, non-streaming function calls. */
136134
public static Maybe<Event> handleFunctionCalls(
137135
InvocationContext invocationContext, Event functionCallEvent, Map<String, BaseTool> tools) {

‎core/src/main/java/com/google/adk/plugins/agentanalytics/BigQuerySchema.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ private BigQuerySchema() {}
6868
"{\"encoding\": \"WKT\"}"));
6969

7070
/** Returns the BigQuery schema for the events table. */
71-
// TODO(b/491848381): Rely on the same schema defined for python plugin.
7271
public static Schema getEventsSchema() {
7372
return Schema.of(
7473
Field.newBuilder("timestamp", StandardSQLTypeName.TIMESTAMP)

0 commit comments

Comments
 (0)