For avx512, combine f, bw, vl, dq into one target #9339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These aren't really worth separating into finer grained targets (there are no relevant CPUs with some avx512 but without these features). Until now, it hasn't really caused much headache to do so, but I'm now trying to clean up partial vector loads/stores to use avx512 instructions for avx or sse sized vectors, and doing so is hard to do while maintaining these fine grained targets. PiperOrigin-RevId: 846939485
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For avx512, combine f, bw, vl, dq into one target
These aren't really worth separating into finer grained targets (there are no relevant CPUs with some avx512 but without these features). Until now, it hasn't really caused much headache to do so, but I'm now trying to clean up partial vector loads/stores to use avx512 instructions for avx or sse sized vectors, and doing so is hard to do while maintaining these fine grained targets.