Update Github workflow build & run destinations, fix respective integration tests#545
Merged
Update Github workflow build & run destinations, fix respective integration tests#545
Conversation
…ll let the default Xcode install choose the run destination. Unit tests will target the generic iOS platform.
…g changes to macos image.
…breaking changes to macos image.
…ilds." This reverts commit 184f5b8.
w-goog
force-pushed
the
wgoog/update-destination
branch
2 times, most recently
from
f83483b to
f740915
Compare
w-goog
force-pushed
the
wgoog/update-destination
branch
from
f740915 to
ae8429f
Compare
…ot appearing on iOS 18 sim)
w-goog
changed the title
Contributor
Author
|
All tests passed on the last run, re-running the prior failure to make sure there's not a hidden flake. |
brnnmrls
reviewed
Aug 19, 2025
brnnmrls
reviewed
Aug 19, 2025
brnnmrls
reviewed
Aug 19, 2025
brnnmrls
reviewed
Aug 19, 2025
brnnmrls
reviewed
Aug 19, 2025
brnnmrls
reviewed
Aug 19, 2025
brnnmrls
requested changes
Aug 19, 2025
Member
brnnmrls
left a comment
brnnmrls
left a comment
There was a problem hiding this comment.
Added a question and nit comments. Overall, looks pretty good!
Contributor
Author
|
Interestingly, this latest failure is due to the mac image only having iOS 26 simulators?!? Fun new failure mode unlocked. |
brnnmrls
reviewed
Aug 20, 2025
...les/Swift/DaysUntilBirthday/DaysUntilBirthdayUITests(iOS)/DaysUntilBirthdayUITests_iOS.swift
Outdated
Show resolved
Hide resolved
brnnmrls
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests are updated to use macOS 15, Xcode 16.4, and iOS 18.6. This also requires an update to the integration tests, which were looking for a different title on the Password Manager field.
Ordinarily, I would see "breakage due to macos-latest/default sims/default xcode" changing as a useful reminder to update our repo. Due to an unfixed bug in the iOS 18.4 simulators and the Github runtimes update, using macOS-latest and the default simulators does not work.
More on Github runtime updates:
Github has opted to support the latest three versions of the platform tools for Xcode. If the default Xcode runtime for a macOS image is not one of those, simulators won't be available. This is currently true of macOS-15, where Xcode 16.0 is the default. As such, we need to specify the Xcode version. I've specified the macOS version as well to ensure that version of Xcode is available.