Exclude GoogleSignInSwift for i386 in addition to armv7#166
Merged
Conversation
paulb777
approved these changes
Jun 1, 2022
petea
changed the title
Alex-4-Git
approved these changes
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up to #157, also exclude GoogleSignInSwift from any i386 build in order to prevent irrelevant build errors.
Due to the iOS 9 deployment version of our Swift package, an unnecessary i386 slice may be built for GoogleSignInSwift in certain scenarios, such as building for a simulator in release configuration.