Skip to content

Commit c139e6a

Browse files
andresusanopintocopybara-github
authored andcommitted
Fix handling of empty parameters in parameter_overview.
The test should not be on whether it is an empty dict, but whether after flattening it is empty. Without this fix the added test fails with: ``` File "../py/clu/parameter_overview.py", line 156, in _get_parameter_rows names, values = map(list, tuple(zip(*sorted(params.items())))) ^^^^^^^^^^^^^ ValueError: not enough values to unpack (expected 2, got 0) ``` PiperOrigin-RevId: 715237667
1 parent 307b0bc commit c139e6a

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

clu/parameter_overview.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,8 +165,8 @@ def _get_parameter_rows(
165165
f"Expected `params` to be a dictionary but got {type(params)}"
166166
)
167167

168+
params = flatten_dict(params)
168169
if params:
169-
params = flatten_dict(params)
170170
names, values = map(list, tuple(zip(*sorted(params.items()))))
171171
else:
172172
names, values = [], []

clu/parameter_overview_test.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,8 @@ def test_count_parameters(self):
9292
def test_get_parameter_overview_empty(self):
9393
self.assertEqual(EMPTY_PARAMETER_OVERVIEW,
9494
parameter_overview.get_parameter_overview({}))
95+
self.assertEqual(EMPTY_PARAMETER_OVERVIEW,
96+
parameter_overview.get_parameter_overview({"a": {}}))
9597

9698
def test_get_parameter_overview(self):
9799
rng = jax.random.PRNGKey(42)

0 commit comments

Comments
 (0)