Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs on camera matrices, flow, depth updated #307

Conversation

mmbannert
Copy link
Contributor

Hi,

I have improved the README.md of the MOVI demos and removed a couple of mistakes. The README now covers some essential information that will be of interest to many users.

  1. As Qwlouse pointed out here, the depth values do not require any rescaling by data_ranges. That discussion further illustrates how the optical flow data can be accessed: They are stored as single-precision floats in the G and R channels of the PNG files. Both depth and optical flow are stored as single-precision floats and not as uint16.
  2. The documentation now states how camera quaternions and positions are combined to obtain (possibly more user-friendly) extrinsic camera matrices and how they are correctly interpreted: i.e., that it describes a camera-to-world transformation and where each positive direction in the world coordinate system points. The description is loosely analogous to the extensive docs of this this dataset.
  3. The docs now briefly describe the availability of the intrinsic camera matrix and how it can be converted to pixel units.

I hope this helps!

Cheers,
Michael

Copy link

google-cla bot commented Nov 27, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Qwlouse
Copy link
Collaborator

Qwlouse commented Mar 4, 2024

Thanks a lot!

@Qwlouse Qwlouse merged commit 5311a27 into google-research:main Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants