Do not use the tool-cache by default (#724)

Author: sethvargo

.github/workflows/integration.yml

@@ -46,28 +46,24 @@ jobs:
         uses: './'
         with:
           skip_install: true
-          skip_tool_cache: true
 
       # Constraint installation
       - name: 'Install constraint'
         uses: './'
         with:
           version: '>= 1.0.0'
-          skip_tool_cache: true
 
       # Default installation
       - name: 'Install version'
         uses: './'
         with:
           version: '374.0.0'
-          skip_tool_cache: true
 
       # Latest installation
       - name: 'Install latest'
         uses: './'
         with:
           version: 'latest'
-          skip_tool_cache: true
 
       # By default, there is no configuration
       - name: 'Check defaults'
@@ -81,7 +77,6 @@ jobs:
         uses: './'
         with:
           install_components: 'cloud-run-proxy'
-          skip_tool_cache: true
 
       - name: 'Check components'
         run: 'npm run integration'
@@ -93,7 +88,6 @@ jobs:
         uses: './'
         with:
           project_id: '${{ vars.PROJECT_ID }}'
-          skip_tool_cache: true
 
       - name: 'Check project ID'
         run: 'npm run integration'
@@ -109,8 +103,6 @@ jobs:
 
       - name: 'Setup gcloud with WIF'
         uses: './'
-        with:
-          skip_tool_cache: true
 
       - name: 'Check WIF authentication'
         run: 'npm run integration'
@@ -126,8 +118,6 @@ jobs:
 
       - name: 'Setup gcloud with SAKE'
         uses: './'
-        with:
-          skip_tool_cache: true
 
       - name: 'Check SAKE authentication'
         run: 'npm run integration'

action.yml

@@ -77,15 +77,12 @@ inputs:
     default: false
     required: false
 
-  skip_tool_cache:
+  cache:
     description: |-
-      Skip transferring the downloaded artifacts into the runner's tool cache.
-      On GitHub-managed runners, this makes no difference since they are
-      ephemeral. On self-hosted runners, this controls whether the downloads are
-      cached stored on the disk.
-
-      For backwards-compatibility, this is is "false" by default. Setting the
-      value to "true" can significantly speed up installation times.
+      Transfer the downloaded artifacts into the runner's tool cache. On
+      GitHub-managed runners, this have very little impact since runneres are
+      ephemeral. On self-hosted runners, this could improve future runs by
+      skipping future gcloud installations.
     default: false
     required: false
 

package-lock.json

@@ -33,7 +33,7 @@
     "@actions/core": "^1.11.1",
     "@actions/tool-cache": "^2.0.2",
     "@google-github-actions/actions-utils": "^0.8.10",
-    "@google-github-actions/setup-cloud-sdk": "^1.2.3"
+    "@google-github-actions/setup-cloud-sdk": "^2.0.0"
   },
   "devDependencies": {
     "@eslint/eslintrc": "^3.3.1",

package.json

@@ -56,7 +56,7 @@ export async function run(): Promise<void> {
     let version = presence(core.getInput('version'));
     const components = core.getInput('install_components');
     const projectId = core.getInput('project_id');
-    const skipToolCache = parseBoolean(core.getInput('skip_tool_cache'));
+    const cache = parseBoolean(core.getInput('cache'));
 
     if (skipInstall) {
       core.info(`Skipping installation ("skip_install" was true)`);
@@ -91,7 +91,7 @@ export async function run(): Promise<void> {
         core.addPath(path.join(toolPath, 'bin'));
       } else {
         core.debug(`no version of gcloud matching "${version}" is installed`);
-        await installGcloudSDK(version, skipToolCache);
+        await installGcloudSDK(version, cache);
       }
     }