Skip to content

Commit a156580

Browse files
authored
Bump to Node 24 (#339)
1 parent 64bc724 commit a156580

File tree

8 files changed

+27
-43
lines changed

8 files changed

+27
-43
lines changed

.github/actionlint.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
paths:
2+
'**/*.yml':
3+
ignore:
4+
# https://github.com/rhysd/actionlint/issues/559
5+
- 'invalid runner name "node24"'

.github/workflows/integration.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
- name: 'npm build'
3737
run: 'npm ci && npm run build'
3838

39-
- uses: 'google-github-actions/auth@v2' # ratchet:exclude
39+
- uses: 'google-github-actions/auth@v3' # ratchet:exclude
4040
with:
4141
workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}'
4242
service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}'
@@ -65,7 +65,7 @@ jobs:
6565
- name: 'npm build'
6666
run: 'npm ci && npm run build'
6767

68-
- uses: 'google-github-actions/auth@v2' # ratchet:exclude
68+
- uses: 'google-github-actions/auth@v3' # ratchet:exclude
6969
with:
7070
workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}'
7171
service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}'

.github/workflows/unit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
- name: 'npm build'
4646
run: 'npm ci && npm run build'
4747

48-
- uses: 'google-github-actions/auth@v2' # ratchet:exclude
48+
- uses: 'google-github-actions/auth@v3' # ratchet:exclude
4949
with:
5050
workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}'
5151
service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}'

README.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ This action requires:
1717
Authorization section below for more information. You also need to
1818
[create a GKE cluster](https://cloud.google.com/kubernetes-engine/docs/quickstart).
1919

20-
- This action runs using Node 20. If you are using self-hosted GitHub Actions
20+
- This action runs using Node 24. If you are using self-hosted GitHub Actions
2121
runners, you must use a [runner
2222
version](https://github.com/actions/virtual-environments) that supports this
2323
version or newer.
@@ -42,13 +42,13 @@ jobs:
4242
4343
steps:
4444
- id: 'auth'
45-
uses: 'google-github-actions/auth@v2'
45+
uses: 'google-github-actions/auth@v3'
4646
with:
4747
project_id: 'my-project'
4848
workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider'
4949
5050
- id: 'get-credentials'
51-
uses: 'google-github-actions/get-gke-credentials@v2'
51+
uses: 'google-github-actions/get-gke-credentials@v3'
5252
with:
5353
cluster_name: 'my-cluster'
5454
location: 'us-central1-a'
@@ -159,13 +159,13 @@ jobs:
159159

160160
steps:
161161
- id: 'auth'
162-
uses: 'google-github-actions/auth@v2'
162+
uses: 'google-github-actions/auth@v3'
163163
with:
164164
project_id: 'my-project'
165165
workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider'
166166

167167
- id: 'get-credentials'
168-
uses: 'google-github-actions/get-gke-credentials@v2'
168+
uses: 'google-github-actions/get-gke-credentials@v3'
169169
with:
170170
cluster_name: 'my-cluster'
171171
location: 'us-central1-a'
@@ -178,12 +178,12 @@ jobs:
178178
job_id:
179179
steps:
180180
- id: 'auth'
181-
uses: 'google-github-actions/auth@v2'
181+
uses: 'google-github-actions/auth@v3'
182182
with:
183183
credentials_json: '${{ secrets.gcp_credentials }}'
184184

185185
- id: 'get-credentials'
186-
uses: 'google-github-actions/get-gke-credentials@v2'
186+
uses: 'google-github-actions/get-gke-credentials@v3'
187187
with:
188188
cluster_name: 'my-cluster'
189189
location: 'us-central1-a'
@@ -201,7 +201,7 @@ jobs:
201201
job_id:
202202
steps:
203203
- id: 'get-credentials'
204-
uses: 'google-github-actions/get-gke-credentials@v2'
204+
uses: 'google-github-actions/get-gke-credentials@v3'
205205
with:
206206
cluster_name: 'my-cluster'
207207
location: 'us-central1-a'
@@ -221,7 +221,7 @@ jobs:
221221
job_id:
222222
steps:
223223
- id: 'get-credentials'
224-
uses: 'google-github-actions/get-gke-credentials@v2'
224+
uses: 'google-github-actions/get-gke-credentials@v3'
225225
with:
226226
cluster_name: 'my-private-cluster'
227227
location: 'us-central1-a'

action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,5 +117,5 @@ branding:
117117
color: 'blue'
118118

119119
runs:
120-
using: 'node20'
120+
using: 'node24'
121121
main: 'dist/main/index.js'

bin/runTests.sh

Lines changed: 0 additions & 21 deletions
This file was deleted.

package-lock.json

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88
"docs": "./node_modules/.bin/actions-gen-readme",
99
"lint": "eslint .",
1010
"format": "eslint . --fix",
11-
"test": "bash ./bin/runTests.sh"
11+
"test": "node --require ts-node/register --test-reporter spec --test tests/**/*.test.ts"
1212
},
1313
"engines": {
14-
"node": ">= 20.x",
14+
"node": ">= 24.x",
1515
"npm": ">= 11.x"
1616
},
1717
"repository": {
@@ -29,7 +29,7 @@
2929
"license": "Apache-2.0",
3030
"dependencies": {
3131
"@actions/core": "^1.11.1",
32-
"@google-github-actions/actions-utils": "^0.8.10",
32+
"@google-github-actions/actions-utils": "^1.0.1",
3333
"google-auth-library": "^10.3.0",
3434
"yaml": "^2.8.1"
3535
},

0 commit comments

Comments
 (0)