Skip to content

Conversation

@jehan60188
Copy link
Contributor

added "comma-seperated" the description for env_vars

This is important when using the literal block scalar | with a variable ${{<variable name>}}, as entries are not parsed separately unless they are comma-seperated (newlines aren't enough)

example:

      - id: "deploy"
        uses: "google-github-actions/deploy-cloud-functions@v2"
        with:
          name: "function_name"
          entry_point: "main"
          runtime: "python311"
          memory_mb: "8192MB"
          env_vars: | 
            FOO=${{ env.PROJECT_NAME }}
            BAR=BAZ
          source_dir: ...

sets one environment variable FOO as <project_name>\nBAR=BAZ

added "comma-seperated"

Signed-off-by: jehan60188 <21280121+jehan60188@users.noreply.github.com>
@jehan60188 jehan60188 requested a review from a team as a code owner December 18, 2023 15:57
@google-cla
Copy link

google-cla bot commented Dec 18, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jehan60188
Copy link
Contributor Author

I just signed the CLA. Do I need to resubmit this PR?

@sethvargo sethvargo merged commit 0451058 into google-github-actions:main Dec 18, 2023
sethvargo pushed a commit that referenced this pull request Jan 23, 2024
## What's Changed
* Update README and CI to use latest version by @sethvargo in
#400
* Update README.md by @jehan60188 in
#401
* Update README.md by @sethvargo in
#402
* Update deps by @sethvargo in
#404

## New Contributors
* @jehan60188 made their first contribution in
#401

**Full Changelog**:
v2.0.0...e0f5010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants