Update README.md #372
Merged
Update README.md #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Why Because when using a JSON env var it fails with a message that says: ``` google-github-actions/deploy-cloud-functions failed with: failed to parse KEY=VALUE pair ""my_key":"my_value"": missing "=" ``` This was happening because an env var was a JSON string and commas were not escaped. Therefore when parsing the env vars it failed when reaching the second key of the JSON string. ## What Adds a clarification to the "env_vars" parameter so that the user knows they need to escape their commas. The clarification was borrowed from the [source code of the function that parses the env vars](https://github.com/google-github-actions/actions-utils/blob/main/src/kv.ts#L43) Signed-off-by: Juan Manuel Ramallo <juanmanuelramallo@hey.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
sethvargo
approved these changes
Feb 14, 2023
Merged
verbanicm
pushed a commit
that referenced
this pull request
May 8, 2023
## What's Changed * Update CI and deps by @sethvargo in #367 * Handle 404 vs other errors when getting the Cloud Function by @sethvargo in #368 * Improve cleanup script by @sethvargo in #369 * Update Readme with ingress_settings valid inputs by @m3h0w in #370 * Update README.md by @juanmanuelramallo in #372 * chore: update dependencies (automated) by @verbanicm in #375 * Switch to pull non-secret values from env by @sethvargo in #376 * Give possible values for memory_mb by @greg-finley in #377 * Add support info by @sethvargo in #380 * chore: update dependencies (automated) by @verbanicm in #382 ## New Contributors * @m3h0w made their first contribution in #370 * @juanmanuelramallo made their first contribution in #372 * @greg-finley made their first contribution in #377 **Full Changelog**: v1.0.0...cc5c68a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Because when using a JSON env var it fails with a message that says:
This was happening because an env var was a JSON string and commas were not escaped. Therefore when parsing the env vars it failed when reaching the second key of the JSON string.
What
Adds a clarification to the "env_vars" parameter so that the user knows they need to escape their commas. The clarification was borrowed from the source code of the function that parses the env vars
Signed-off-by: Juan Manuel Ramallo juanmanuelramallo@hey.com