Refactor Grid1D to be defined by face_centers rather than number of grid points. #1877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_852231271
branch
3 times, most recently
from
1acebdc to
599ea6b
Compare
…rid points. The legacy input is still supported by a pydantic before validator. Regen sim because of O(1e-16) changes in grid coordinates. PiperOrigin-RevId: 852231271
copybara-service
bot
force-pushed
the
test_852231271
branch
from
599ea6b to
127d570
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Grid1D to be defined by face_centers rather than number of grid points.
The legacy input is still supported by a pydantic before validator.
Regen sim because of O(1e-16) changes in grid coordinates.