improve testing for batched Model fields
#962
Draft
+43
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thowell
force-pushed
the
test_model_batched_fields
branch
from
394fff4 to
d5c6a14
Compare
Collaborator
Author
|
@Kenny-Vilella @adenzler-nvidia is there a recommended approach for checking if any out of bounds reads occur on cpu? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr aims to improve testing for batched
Modelfields. hopefully we can prevent bugs like the ones fixed in #865, #932, #821, #819, #807, #800notes:
--debug_modedoes not work with--cpuso the changes to ci.yml will not currently work with the github actions cpu-based ci