GitHub CI: separate release and dev tests #917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikfrey
requested changes
Dec 13, 2025
erikfrey
requested changes
Dec 29, 2025
.github/workflows/ci.yml
Outdated
| - name: Uninstall nightly warp-lang and install release warp-lang | ||
| if: matrix.warp-version == 'release' | ||
| run: | | ||
| pip uninstall -y warp-lang |
Collaborator
There was a problem hiding this comment.
OK but we also want to use the release version of mujoco, right? Basically any non-nightlies?
Rather than explicitly uninstalling/reinstalling, which might be a source of error, can you rely on the deps in pyproject.toml? it may require you to tweak the optional dependencies so that we have a way of installing dev with nightly deps and dev with release deps, so it might look something like:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install uv
uv pip install --system -e .[${{ matrix.deps-version == 'release' && 'dev-release' || 'dev' }},cpu]
thowell
changed the title
thowell
force-pushed
the
ci
branch
3 times, most recently
from
695f28e to
7440cd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to ci.yml to test release and dev versions of warp-lang and mujoco