Fix issue #145: bookmarks without images (#156)

* chore: release v0.4.3 (#149)

* chore: release v0.4.1-hotfix.3

* fix(data-migration): early return if no categories have parents (#128)

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* Closes #130 (#131)

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* fix(database): use dynamic path for SQLite database file

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* docs(readme): use single README file for latest/preview version

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* feat(ci): add manual deployment workflow and adjust tag conditions

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* refactor(workflow): simplify manual-deploy GitHub Action

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* fix(metadata): handle multiple image URLs in mainImageUrl field

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* fix: auth error handling (#144)

* refactor(api): migrate Swagger UI to external documentation and enhance health endpoint

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>

* chore: release v0.4.3

---------

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>
Co-authored-by: Prabhanjan <zetabytes.pp@gmail.com>

* Fix bookmark creation/update without image

---------

Signed-off-by: Robert Goniszewski <robertgoniszewski@outlook.com>
Co-authored-by: Robert Goniszewski <43510122+goniszewski@users.noreply.github.com>
Co-authored-by: Prabhanjan <zetabytes.pp@gmail.com>

Author: 3 people

src/routes/+page.server.ts

@@ -71,16 +71,15 @@ export const actions = {
 					error: 'Failed to add bookmark'
 				};
 			}
-			const { id: mainImageId } = await storage.storeImage(
-				mainImageUrl,
-				title,
-				ownerId,
-				bookmark.id
-			);
-			const { id: iconId } = await storage.storeImage(iconUrl, title, ownerId, bookmark.id);
+			const mainImage = mainImageUrl
+				? await storage.storeImage(mainImageUrl, title, ownerId, bookmark.id)
+				: undefined;
+			const icon = iconUrl
+				? await storage.storeImage(iconUrl, title, ownerId, bookmark.id)
+				: undefined;
 			const updatedBookmark = await updateBookmark(bookmark.id, ownerId, {
-				mainImageId,
-				iconId
+				...(mainImage ? { mainImageId: mainImage.id } : {}),
+				...(icon ? { iconId: icon.id } : {})
 			});
 
 			await upsertTagsForBookmark(bookmark.id, ownerId, tagNames);
@@ -149,8 +148,10 @@ export const actions = {
 
 		const tagNames = tags.map((tag: any) => tag.label);
 
-		const { id: mainImageId } = await storage.storeImage(mainImageUrl, title, ownerId, id);
-		const { id: iconId } = await storage.storeImage(iconUrl, title, ownerId, id);
+		const mainImage = mainImageUrl
+			? await storage.storeImage(mainImageUrl, title, ownerId, id)
+			: undefined;
+		const icon = iconUrl ? await storage.storeImage(iconUrl, title, ownerId, id) : undefined;
 
 		const bookmarkData = {
 			author,
@@ -169,8 +170,8 @@ export const actions = {
 			title,
 			url,
 			read,
-			...(mainImageId ? { mainImageId } : {}),
-			...(iconId ? { iconId } : {})
+			...(mainImage ? { mainImageId: mainImage.id } : {}),
+			...(icon ? { iconId: icon.id } : {})
 		};
 
 		const bookmark = await updateBookmark(id, ownerId, bookmarkData);