Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go.mod marking this +incompatible for Go 1.11 when doing go get #365

Closed
bjm88 opened this issue Sep 23, 2018 · 3 comments
Closed

Go.mod marking this +incompatible for Go 1.11 when doing go get #365

bjm88 opened this issue Sep 23, 2018 · 3 comments

Comments

@bjm88
Copy link

bjm88 commented Sep 23, 2018

AFter upgrading from go 1.10 to go 1.11 which now includes vgo as standard module / version manager this library is getting adding to go.mod file after go get, but its also marking it "incompatible"

github.com/gomodule/redigo v2.0.0+incompatible // indirect

Believe need to upgrade this libraries meta data to support new ways of 1.11 / vgo.

@elithrar
Copy link

Are you running into issues building redigo? If so, please share the output of the Go tool you’re using.

Note the discussion in #363

@bjm88
Copy link
Author

bjm88 commented Sep 23, 2018

I am able to build, so its not blocking, maybe just concerning and confusing for people new to go. I believe the go 1.11 is handling the incompatibility under the covers for now. Still, loving 1.11 and vgo integration, much cleaner and great for community collaboration and supporting new workspace layouts like monolithic repos and moving away from GOPATH.

@garyburd
Copy link
Member

Let's continue discussion in #366.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants