Fix InvalidStateError on IE11 when playing sound
#1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our use of howler.js, IE11 is throwing an `InvalidStateError`, but the problem is resolved by making sure we can set `currentTime` on this line
|
Do you have a sample of what leads to that error? I haven't been able to reproduce this and want to make sure there isn't another issue further up the chain. |
|
I believe this sample did it: The howler included should be patched, but it's separate (under "lib") so it should be possible to experiment with another version of the library Thank you 😄 |
|
I still can't reproduce this on my end, but I also don't see any issue with adding that check, so I've merged this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our use of howler.js, IE11 is throwing an
InvalidStateError, but the problem is resolved by making sure we can setcurrentTimeon this line