Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type definitions in the NPM package #1032

Open
turadg opened this issue Aug 31, 2018 · 3 comments
Open

Type definitions in the NPM package #1032

turadg opened this issue Aug 31, 2018 · 3 comments

Comments

@turadg
Copy link
Contributor

turadg commented Aug 31, 2018

Feature request for official type definitions, ideally packaged in the NPM distribution.

This came up two years ago in #584 and was rejected but since then TypeScript and Flow have taken off.

@goldfire
Copy link
Owner

goldfire commented Sep 7, 2018

Does the @types/howler library not work? https://www.npmjs.com/package/@types/howler

@turadg
Copy link
Contributor Author

turadg commented Sep 7, 2018

Yes for Typescript and no for Flow.

I hadn't seen that @types/howler package but I assume it works well for TypeScript. It would be nice to have those managed in the howler package itself, but not a big deal.

However, there are no types for Flow. So I'd still like to advocate for official type defs in this repo, perhaps that generated by def styles.

@Greenheart
Copy link

I added native TypeScript definition exports while I refactored the core modules to native ESM today.

Check it out and please help out if you also want to see this in production! :)

#1518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants