Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add go-header linter #1181

Merged
merged 8 commits into from
Jul 4, 2020
Merged

Add go-header linter #1181

merged 8 commits into from
Jul 4, 2020

Conversation

denis-tingaikin
Copy link
Member

@denis-tingaikin denis-tingaikin commented Jun 7, 2020 •
edited
Loading

Signed-off-by: denis-tingajkin denis.tingajkin@xored.com

#1180

@boring-cyborg
Copy link

boring-cyborg bot commented Jun 7, 2020

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@denis-tingaikin
add go-header linter
adb1a45 
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
@denis-tingaikin
fix go mod issue
ed39ee9 
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
@denis-tingaikin
fix some issues
6850237 
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
@denis-tingaikin denis-tingaikin changed the title WIP: Add go-header linter Add go-header linter Jun 21, 2020
@denis-tingaikin
checkout README.md
6e8a56e 
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
denis-tingaikin
denis-tingaikin commented Jun 21, 2020
View reviewed changes
test/linters_test.go Outdated Show resolved Hide resolved
@denis-tingaikin denis-tingaikin marked this pull request as ready for review June 21, 2020 06:51
sayboras
sayboras reviewed Jun 21, 2020
View reviewed changes
go.sum Outdated Show resolved Hide resolved
@denis-tingaikin
go mod tidy
e61192d 
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
sayboras
sayboras approved these changes Jun 21, 2020
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor nits on docs and example. Let's see if other have other comment.

@denis-tingaikin
apply review comments: add goheader example into .golangci.example.yml
d52fb3a 
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
iwankgb
iwankgb reviewed Jul 4, 2020
View reviewed changes
test/linters_test.go Outdated Show resolved Hide resolved
iwankgb
iwankgb requested changes Jul 4, 2020
View reviewed changes
test/linters_test.go Outdated Show resolved Hide resolved
@denis-tingaikin
Copy link
Member Author

@iwankgb please take a look at comment #1181 (comment)

@denis-tingaikin
apply review comments: better to use more conservative solution to su…
246fdaf 
…pport headers checking for golangci linter

Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
@denis-tingaikin
apply review comments: correctly handle multiline comments
28fc9e0 
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
@iwankgb iwankgb merged commit 01b566a into golangci:master Jul 4, 2020
@golangci-automator
Copy link

Hey, @denis-tingajkin — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

@invidian invidian mentioned this pull request Jul 4, 2020
Open
@denis-tingaikin denis-tingaikin mentioned this pull request Jul 5, 2020
Closed
@mstoykov mstoykov mentioned this pull request Oct 26, 2020
Merged
@ldez ldez added the linter: new Support new linter label Dec 7, 2020
This was referenced Feb 2, 2022
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 23, 2022
Open
@mansong1 mansong1 mentioned this pull request Jun 25, 2023
Open
@oat-eknarin-hugeman oat-eknarin-hugeman mentioned this pull request Jul 4, 2023
Open
@irinazheltisheva irinazheltisheva mentioned this pull request Jul 4, 2023
Open
@mansong1 mansong1 mentioned this pull request Jul 5, 2023
Open
This was referenced Jul 20, 2023
Open
Open
Open
@irinazheltisheva irinazheltisheva mentioned this pull request Aug 11, 2023
Open
@irinazheltisheva irinazheltisheva mentioned this pull request Sep 26, 2023
Open
@irinazheltisheva irinazheltisheva mentioned this pull request Oct 4, 2023
Open
@mansong1 mansong1 mentioned this pull request Nov 26, 2023
Open
@geraldywy geraldywy mentioned this pull request Nov 28, 2023
Open
@ldez ldez added this to the v1.28 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

@iwankgb iwankgb iwankgb approved these changes

Assignees
No one assigned
Labels
linter: new Support new linter
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
5 participants
@denis-tingaikin @CLAassistant @iwankgb @sayboras @ldez