feat: add reusestdlibvars

Author: sashamelentyev

.golangci.reference.yml

@@ -1911,6 +1911,7 @@ linters:
     - prealloc
     - predeclared
     - promlinter
+    - reusestdlibvars
     - revive
     - rowserrcheck
     - scopelint
@@ -2012,6 +2013,7 @@ linters:
     - prealloc
     - predeclared
     - promlinter
+    - reusestdlibvars
     - revive
     - rowserrcheck
     - scopelint

go.mod

@@ -74,6 +74,7 @@ require (
 	github.com/ryancurrah/gomodguard v1.2.3
 	github.com/ryanrolds/sqlclosecheck v0.3.0
 	github.com/sanposhiho/wastedassign/v2 v2.0.6
+	github.com/sashamelentyev/reusestdlibvars v1.3.0
 	github.com/securego/gosec/v2 v2.12.0
 	github.com/shazow/go-diff v0.0.0-20160112020656-b6b7b6733b8c
 	github.com/shirou/gopsutil/v3 v3.22.6

go.sum

@@ -0,0 +1,19 @@
+package golinters
+
+import (
+	"github.com/sashamelentyev/reusestdlibvars/pkg/analyzer"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+func NewReuseStdlibVars() *goanalysis.Linter {
+	a := analyzer.New()
+
+	return goanalysis.NewLinter(
+		a.Name,
+		a.Doc,
+		[]*analysis.Analyzer{a},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeSyntax)
+}

pkg/golinters/reusestdlibvars.go

@@ -665,6 +665,11 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithPresets(linter.PresetStyle).
 			WithURL("https://github.com/yeya24/promlinter"),
 
+		linter.NewConfig(golinters.NewReuseStdlibVars()).
+			WithSince("v1.48.0").
+			WithPresets(linter.PresetStyle).
+			WithURL("https://github.com/sashamelentyev/reusestdlibvars"),
+
 		linter.NewConfig(golinters.NewRevive(reviveCfg)).
 			WithSince("v1.37.0").
 			WithPresets(linter.PresetStyle, linter.PresetMetaLinter).

pkg/lint/lintersdb/manager.go

@@ -0,0 +1,89 @@
+//golangcitest:args -Ereusestdlibvars
+package testdata
+
+import "net/http"
+
+func _200() {
+	_ = 200
+}
+
+func _200_1() {
+	var w http.ResponseWriter
+	w.WriteHeader(200) // ERROR `can use http.StatusOK instead "200"`
+}
+
+func sunday() {
+	_ = "Sunday" // ERROR `can use time.Sunday.String\(\) instead "Sunday"`
+}
+
+func monday() {
+	_ = "Monday" // ERROR `can use time.Monday.String\(\) instead "Monday"`
+}
+
+func tuesday() {
+	_ = "Tuesday" // ERROR `can use time.Tuesday.String\(\) instead "Tuesday"`
+}
+
+func wednesday() {
+	_ = "Wednesday" // ERROR `can use time.Wednesday.String\(\) instead "Wednesday"`
+}
+
+func thursday() {
+	_ = "Thursday" // ERROR `can use time.Thursday.String\(\) instead "Thursday"`
+}
+
+func friday() {
+	_ = "Friday" // ERROR `can use time.Friday.String\(\) instead "Friday"`
+}
+
+func saturday() {
+	_ = "Saturday" // ERROR `can use time.Saturday.String\(\) instead "Saturday"`
+}
+
+func january() {
+	_ = "January" // ERROR `can use time.January.String\(\) instead "January"`
+}
+
+func february() {
+	_ = "February" // ERROR `can use time.February.String\(\) instead "February"`
+}
+
+func march() {
+	_ = "March" // ERROR `can use time.March.String\(\) instead "March"`
+}
+
+func april() {
+	_ = "April" // ERROR `can use time.April.String\(\) instead "April"`
+}
+
+func may() {
+	_ = "May" // ERROR `can use time.May.String\(\) instead "May"`
+}
+
+func june() {
+	_ = "June" // ERROR `can use time.June.String\(\) instead "June"`
+}
+
+func july() {
+	_ = "July" // ERROR `can use time.July.String\(\) instead "July"`
+}
+
+func august() {
+	_ = "August" // ERROR `can use time.August.String\(\) instead "August"`
+}
+
+func september() {
+	_ = "September" // ERROR `can use time.September.String\(\) instead "September"`
+}
+
+func october() {
+	_ = "October" // ERROR `can use time.October.String\(\) instead "October"`
+}
+
+func november() {
+	_ = "November" // ERROR `can use time.November.String\(\) instead "November"`
+}
+
+func december() {
+	_ = "December" // ERROR `can use time.December.String\(\) instead "December"`
+}