Github action fails to find issues which a manual run inside the action finds

[veqryn]

Welcome

• Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
• Yes, I've searched similar issues on GitHub and didn't find any.
• Yes, I've read the typecheck section of the FAQ (https://golangci-lint.run/usage/faq/#why-do-you-have-typecheck-errors).
• Yes, I've tried with the standalone linter if available (e.g., gocritic, go vet, etc.). (https://golangci-lint.run/usage/linters/)

Description of the problem

I have a github repo with multiple golang modules in it.
I found that running golangci-lint run ./... at the root will not find issues in any modules that are in sub-directories (maybe another bug?).
However, changing working directory to the golang sub-module and running the above will find the issues.
Because of that, I have created a github action that runs golangci-lint each in golang module.

However, the "github action" version of golangci-lint fails to find problems, while running golangci-lint run ./... manually in the github action does find the problems.

Here are two example runs from my public repo:
https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1
https://github.com/veqryn/slog-context/actions/runs/7069162742/job/19244558387?pr=1

Version of golangci-lint

golangci-lint-1.55.2-linux-amd64

Configuration

run:
  tests: false

Go environment

go 1.21.4 (inside github action)

  GO111MODULE=''
  GOARCH='amd64'
  GOBIN=''
  GOCACHE='/home/runner/.cache/go-build'
  GOENV='/home/runner/.config/go/env'
  GOEXE=''
  GOEXPERIMENT=''
  GOFLAGS=''
  GOHOSTARCH='amd64'
  GOHOSTOS='linux'
  GOINSECURE=''
  GOMODCACHE='/home/runner/go/pkg/mod'
  GONOPROXY=''
  GONOSUMDB=''
  GOOS='linux'
  GOPATH='/home/runner/go'
  GOPRIVATE=''
  GOPROXY='https://proxy.golang.org,direct'
  GOROOT='/opt/hostedtoolcache/go/1.21.4/x64'
  GOSUMDB='sum.golang.org'
  GOTMPDIR=''
  GOTOOLCHAIN='auto'
  GOTOOLDIR='/opt/hostedtoolcache/go/1.21.4/x64/pkg/tool/linux_amd64'
  GOVCS=''
  GOVERSION='go1.21.4'
  GCCGO='gccgo'
  GOAMD64='v1'
  AR='ar'
  CC='gcc'
  CXX='g++'
  CGO_ENABLED='1'
  GOMOD='/home/runner/work/slog-context/slog-context/go.mod'
  GOWORK=''
  CGO_CFLAGS='-O2 -g'
  CGO_CPPFLAGS=''
  CGO_CXXFLAGS='-O2 -g'
  CGO_FFLAGS='-O2 -g'
  CGO_LDFLAGS='-O2 -g'
  PKG_CONFIG='pkg-config'
  GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build58[18](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:3:19)034[27](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:3:28)=/tmp/go-build -gno-record-gcc-switches'

Verbose output of running

Run golangci/golangci-lint-action@v3
  with:
    version: latest
    working-directory: ./examples
    only-new-issues: false
    github-token: ***
    skip-cache: false
    skip-pkg-cache: false
    skip-build-cache: false
    install-mode: binary
prepare environment
  Checking for go.mod: examples/go.mod
  Received 0 of [2](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:4:2)4202291 (0.0%), 0.0 MBs/sec
  Cache Size: ~2[3](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:4:3) MB (2[4](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:4:4)202291 B)
  /usr/bin/tar -xf /home/runner/work/_temp/0384dced-cfaf-47d6-88b2-a6ea97d6e940/cache.tzst -P -C /home/runner/work/slog-context/slog-context --use-compress-program unzstd
  Cache restored successfully
  Restored cache for golangci-lint from key 'golangci-lint.cache-2813-[5](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:4:5)[6](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:4:6)82e8f02fa4551[7](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:4:7)0[8](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:4:8)86fc251c[9](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:4:9)7c933926fe41d' in 2353ms
  Finding needed golangci-lint version...
  Requested golangci-lint 'latest', using 'v1.55.2', calculation took 15ms
  Installation mode: binary
  Installing golangci-lint binary v1.55.2...
  Downloading binary https://github.com/golangci/golangci-lint/releases/download/v1.55.2/golangci-lint-1.55.2-linux-amd64.tar.gz ...
  /usr/bin/tar xz --overwrite --warning=no-unknown-keyword --overwrite -C /home/runner -f /home/runner/work/_temp/341f3ea5-74e8-4b33-b4d8-2944c26e3d05
  Received 24202291 of 24202291 ([10](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:4:10)0.0%), [11](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:4:12).5 MBs/sec
  Installed golangci-lint into /home/runner/golangci-lint-1.55.2-linux-amd64/golangci-lint in 401ms
  Prepared env in 2770ms
run golangci-lint
  Running [/home/runner/golangci-lint-1.55.2-linux-amd64/golangci-lint run --out-format=github-actions --path-prefix=./examples] in [/home/runner/work/slog-context/slog-context/examples] ...
  golangci-lint found no issues
  Ran golangci-lint in 397ms

Run pwd
  pwd
  ls -la
  golangci-lint run ./...
  golangci-lint run ./open-telemetry/open-telemetry-main.go
  shell: /usr/bin/bash -e {0}
/home/runner/work/slog-context/slog-context/examples
total 3[2](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:5:2)
drwxr-xr-x 6 runner docker 4096 Dec  2 08:[3](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:5:3)[4](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:5:4) .
drwxr-xr-x 6 runner docker 4096 Dec  2 08:34 ..
drwxr-xr-x 2 runner docker 4096 Dec  2 08:34 attributes-in-ctx
drwxr-xr-x 2 runner docker 4096 Dec  2 08:34 context-value-extractor
-rw-r--r-- 1 runner docker  [5](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:5:5)19 Dec  2 08:34 go.mod
-rw-r--r-- 1 runner docker 2713 Dec  2 08:34 go.sum
drwxr-xr-x 2 runner docker 409[6](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:5:6) Dec  2 0[8](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:5:9):34 logger-in-ctx
drwxr-xr-x 2 runner docker 40[9](https://github.com/veqryn/slog-context/actions/runs/7069141193/job/19244513761?pr=1#step:5:10)6 Dec  2 08:34 open-telemetry
Error: open-telemetry/open-telemetry-main.go:44:30: Error return value of `traceProvider.Shutdown` is not checked (errcheck)
	defer traceProvider.Shutdown(context.Background())
	                            ^
Error: Process completed with exit code 1.

A minimal reproducible example or link to a public repository

name: golangci-lint
on:
  push:
    branches:
      - main
  pull_request:
permissions:
  contents: read
  pull-requests: read
jobs:
  golangci:
    name: lint
    runs-on: ubuntu-latest
    strategy:
      matrix:
        go-module: [ '.', './otel', './examples']
    defaults:
      run:
        working-directory: ${{ matrix.go-module }}
    steps:
      - uses: actions/checkout@v4
      - uses: actions/setup-go@v4
        with:
          go-version: 'stable'
          cache: false
      - name: Github-action golangci-lint ${{ matrix.go-module }}
        uses: golangci/golangci-lint-action@v3
        with:
          version: latest
          only-new-issues: true
      - name: Manual golangci-lint ${{ matrix.go-module }}
        run: golangci-lint run ./...

Validation

• Yes, I've included all information above (version, config, etc.).

[boring-cyborg[bot]]

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

[veqryn]

I'm not sure why this was moved to "discussion". I consider it a bug that the default github action fails to find issues that a manual run (from inside a github action) finds...