Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test codelens redundant function #1417

Closed
endlesstravel opened this issue Apr 11, 2021 · 1 comment
Closed

test codelens redundant function #1417

endlesstravel opened this issue Apr 11, 2021 · 1 comment
Assignees
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@endlesstravel
Copy link

endlesstravel commented Apr 11, 2021

Description:

test codelens redundant function:
name start with Test[a-z] is not considered as test for go test
for example function TestaAbug is not not run in go test, but codelen is show run test | debug test on function.

Screenshots or recordings

image

image

Environment:

go version go1.16.3 windows/amd64
gopls -v version
Build info
----------
golang.org/x/tools/gopls v0.6.9
    golang.org/x/tools/gopls@v0.6.9 h1:LBBcE2y3Tb4bp79JVLWCQBbvYCFEs5ADGWsQDoSLk1Q=
    github.com/BurntSushi/toml@v0.3.1 h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
    github.com/google/go-cmp@v0.5.4 h1:L8R9j+yAqZuZjsqh/z+F1NCffTKKLShY6zXTItVIZ8M=
    github.com/sergi/go-diff@v1.1.0 h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
    golang.org/x/mod@v0.4.1 h1:Kvvh58BN8Y9/lBi7hTekvtMpm07eUZ0ck5pRHpsMWrY=
    golang.org/x/sync@v0.0.0-20201020160332-67f06af15bc9 h1:SQFwaSi55rU7vdNs9Yr0Z324VNlrF+0wMqRXT4St8ck=
    golang.org/x/sys@v0.0.0-20210124154548-22da62e12c0c h1:VwygUrnw9jn88c4u8GD3rZQbqrP/tgas88tPUbBxQrk=
    golang.org/x/tools@v0.1.1-0.20210319172145-bda8f5cee399 h1:O5bm8buX/OaamnfcBrkjn0SPUIU30jFmaS8lP+ikkxs=
    golang.org/x/xerrors@v0.0.0-20200804184101-5ec99f83aff1 h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=
    honnef.co/go/tools@v0.1.1 h1:EVDuO03OCZwpV2t/tLLxPmPiomagMoBOgfPt0FM+4IY=
    mvdan.cc/gofumpt@v0.1.0 h1:hsVv+Y9UsZ/mFZTxJZuHVI6shSQCtzZ11h1JEFPAZLw=
    mvdan.cc/xurls/v2@v2.2.0 h1:NSZPykBXJFCetGZykLAxaL6SIpvbVy/UFEniIfHAa8A=
code -v
1.55.1
08a217c4d27a02a5bcde898fd7981bda5b49391b
x64
Checking configured tools....
GOBIN: undefined
toolsGopath: 
gopath: C:\Users\Yx\go
GOROOT: D:\Program Files\Go
PATH: C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common;C:\Program Files\NVIDIA Corporation\NVIDIA NvDLISR;D:\_shortcut;C:\Program Files (x86)\Git\cmd;C:\Program Files\nodejs\;C:\Program Files\dotnet\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\WINDOWS\System32\OpenSSH\;D:\neko-2.3.0-win64;D:\Program Files\Go\bin;D:\TDM-GCC-64\bin;C:\Users\Yx\AppData\Local\Programs\Python\Python39\Scripts\;C:\Users\Yx\AppData\Local\Programs\Python\Python39\;C:\Users\Yx\AppData\Local\Microsoft\WindowsApps;;C:\Users\Yx\AppData\Local\Programs\Microsoft VS Code\bin;C:\Users\Yx\AppData\Roaming\npm;C:\Users\Yx\.dotnet\tools;C:\Users\Yx\go\bin

   gopkgs: C:\Users\Yx\go\bin\gopkgs.exe installed
   go-outline: C:\Users\Yx\go\bin\go-outline.exe installed
   gotests: C:\Users\Yx\go\bin\gotests.exe installed
   gomodifytags: C:\Users\Yx\go\bin\gomodifytags.exe installed
   impl: C:\Users\Yx\go\bin\impl.exe installed
   goplay: C:\Users\Yx\go\bin\goplay.exe installed
   dlv: C:\Users\Yx\go\bin\dlv.exe installed
   dlv-dap: C:\Users\Yx\go\bin\dlv-dap.exe installed
   staticcheck: C:\Users\Yx\go\bin\staticcheck.exe installed
   gopls: C:\Users\Yx\go\bin\gopls.exe installed

go env
Workspace Folder (hine): d:\test_ppp\hine
	set GO111MODULE=on
	set GOARCH=amd64
	set GOBIN=
	set GOCACHE=C:\Users\Yx\AppData\Local\go-build
	set GOENV=C:\Users\Yx\AppData\Roaming\go\env
	set GOEXE=.exe
	set GOFLAGS=
	set GOHOSTARCH=amd64
	set GOHOSTOS=windows
	set GOINSECURE=
	set GOMODCACHE=C:\Users\Yx\go\pkg\mod
	set GONOPROXY=
	set GONOSUMDB=
	set GOOS=windows
	set GOPATH=C:\Users\Yx\go
	set GOPRIVATE=
	set GOPROXY=https://goproxy.cn,direct
	set GOROOT=D:\Program Files\Go
	set GOSUMDB=sum.golang.org
	set GOTMPDIR=
	set GOTOOLDIR=D:\Program Files\Go\pkg\tool\windows_amd64
	set GOVCS=
	set GOVERSION=go1.16.3
	set GCCGO=gccgo
	set AR=ar
	set CC=gcc
	set CXX=g++
	set CGO_ENABLED=1
	set GOMOD=d:\test_ppp\hine\go.mod
	set CGO_CFLAGS=-g -O2
	set CGO_CPPFLAGS=
	set CGO_CXXFLAGS=-g -O2
	set CGO_FFLAGS=-g -O2
	set CGO_LDFLAGS=-g -O2
	set PKG_CONFIG=pkg-config
	set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\Yx\AppData\Local\Temp\go-build3996959707=/tmp/go-build -gno-record-gcc-switches
@gopherbot gopherbot added this to the Untriaged milestone Apr 11, 2021
@heschi heschi modified the milestones: Untriaged, Backlog Apr 12, 2021
@heschi heschi added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 12, 2021
@hyangah hyangah self-assigned this Apr 13, 2021
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/309631 mentions this issue: src/testUtils: tighten test function detection regex

@stamblerre stamblerre modified the milestones: Backlog, v0.24.1 Apr 14, 2021
@hyangah hyangah modified the milestones: Backlog, v0.24.1 Apr 14, 2021
@golang golang locked and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

5 participants