gopls/internal/analysis: add fill switch cases code action #476

martskins · 2024-02-05T18:55:25Z

This PR adds a code action to fill missing cases on type switches and
switches on named types.

Rules are defined here: golang/go#65411 (comment).

Edit: I added some tests, but I'm sure there are still things to fix so
sharing to get some feedback.

Fixes golang/go#65411

fillswitch2.mov

gopherbot · 2024-02-05T19:08:21Z

This PR (HEAD: f845a17) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/561416.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-05T19:21:50Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-05T19:21:50Z

Message from tricium-prod@appspot.gserviceaccount.com:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-05T22:04:11Z

This PR (HEAD: d362e75) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/561416.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-05T22:41:41Z

Message from Martin:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-06T00:19:20Z

This PR (HEAD: 320bf61) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/561416.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-06T08:51:38Z

This PR (HEAD: 5700ad1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/561416.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-06T08:58:13Z

This PR (HEAD: 567689d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/561416.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-06T09:11:03Z

This PR (HEAD: 7bf4ea0) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/561416.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-07T02:32:26Z

Message from Alan Donovan:

Patch Set 11:

(19 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-07T08:20:01Z

This PR (HEAD: 3fcf757) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/561416.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-07T08:43:12Z

This PR (HEAD: e2e08f6) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/561416.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-07T09:14:57Z

Message from Martin:

Patch Set 13:

(19 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-08T21:17:36Z

Message from Alan Donovan:

Patch Set 13:

(14 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-09T12:02:00Z

Message from Martin:

Patch Set 13:

(13 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-09T14:36:05Z

This PR (HEAD: 3ad4cf6) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/561416.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-09T14:42:26Z

Message from Martin:

Patch Set 13:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-09T14:55:38Z

Message from Martin:

Patch Set 14:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-09T14:55:43Z

This PR (HEAD: c8fda66) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/561416.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-09T16:38:22Z

Message from Alan Donovan:

Patch Set 15:

(24 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T18:08:19Z

This PR (HEAD: a04dc69) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/561416.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-23T18:14:51Z

Message from Martin:

Patch Set 24:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T18:14:51Z

Message from Robert Findley:

Patch Set 24: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T18:14:52Z

Message from Go LUCI:

Patch Set 24:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-23T18:06:55Z","revision":"acbe50340ae2104b22182fd264662d1a36ea4cba"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T18:14:52Z

Message from Go LUCI:

Patch Set 24: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T18:34:57Z

Message from Robert Findley:

Patch Set 25: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T18:41:16Z

Message from Go LUCI:

Patch Set 25:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-23T18:24:24Z","revision":"d038623b42e3c4f02d732f0ae8470d1e1453c268"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T18:47:49Z

Message from Robert Findley:

Patch Set 25: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T18:47:50Z

Message from Go LUCI:

Patch Set 25:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T18:47:50Z

Message from Go LUCI:

Patch Set 25: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T19:12:54Z

Message from Robert Findley:

Patch Set 25: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/561416.
After addressing review feedback, remember to publish your drafts!

This PR adds a code action to fill missing cases on type switches and switches on named types. Rules are defined here: golang/go#65411 (comment). Edit: I added some tests, but I'm sure there are still things to fix so sharing to get some feedback. Fixes golang/go#65411 https://github.com/golang/tools/assets/4250565/1e67c404-e24f-478e-a3df-60a3adfaa9b1 Change-Id: Ie4ef0955d0e7ca130af8980a488b738c812aae4d GitHub-Last-Rev: a04dc69 GitHub-Pull-Request: #476 Reviewed-on: https://go-review.googlesource.com/c/tools/+/561416 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Alan Donovan <adonovan@google.com>

gopherbot · 2024-02-28T16:24:09Z

This PR is being closed because golang.org/cl/561416 has been merged.

martskins force-pushed the fill-switch branch from f845a17 to d362e75 Compare February 5, 2024 22:03

martskins changed the title ~~gopls: add fill switch cases code action~~ gopls/internal/analysis: add fill switch cases code action Feb 5, 2024

martskins force-pushed the fill-switch branch 2 times, most recently from bfd0297 to 320bf61 Compare February 6, 2024 00:18

martskins force-pushed the fill-switch branch from 320bf61 to 5700ad1 Compare February 6, 2024 08:44

martskins force-pushed the fill-switch branch from 5700ad1 to 567689d Compare February 6, 2024 08:53

martskins force-pushed the fill-switch branch from 567689d to 7bf4ea0 Compare February 6, 2024 09:02

martskins marked this pull request as ready for review February 6, 2024 17:37

martskins force-pushed the fill-switch branch from 672f97b to 3ad4cf6 Compare February 9, 2024 14:33

martskins force-pushed the fill-switch branch from 3ad4cf6 to c8fda66 Compare February 9, 2024 14:54

martskins added 15 commits February 23, 2024 17:56

multiple fixes

901c2b0

collect types/consts instead of strings

c43c2d9

return edits on diagnostic

c84559b

more fixes

c4feaf3

introduce namedVariant

344eae7

update documentation

4066149

remove unnecessary errors

2a470ab

invert order of handledVariants and variants calculations

388646e

more fixes

2f874f5

add default case

3e1e812

fix documentation and handle ast.CallExpr as switch tag

c22e6fb

use types.WriteExpr instead of types.ExprString

9fbd6c5

do not use types.WriteExpr

bb09468

refactor addDefaultCase

0cbc264

move writeDotted into addDefaultCase

a04dc69

martskins force-pushed the fill-switch branch from 1945e56 to a04dc69 Compare February 23, 2024 18:06

gopherbot closed this Feb 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gopls/internal/analysis: add fill switch cases code action #476

gopls/internal/analysis: add fill switch cases code action #476

martskins commented Feb 5, 2024 •

edited

Loading

gopherbot commented Feb 5, 2024

gopherbot commented Feb 5, 2024

gopherbot commented Feb 5, 2024

gopherbot commented Feb 5, 2024

gopherbot commented Feb 5, 2024

gopherbot commented Feb 6, 2024

gopherbot commented Feb 6, 2024

gopherbot commented Feb 6, 2024

gopherbot commented Feb 6, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 8, 2024

gopherbot commented Feb 9, 2024

gopherbot commented Feb 9, 2024

gopherbot commented Feb 9, 2024

gopherbot commented Feb 9, 2024

gopherbot commented Feb 9, 2024

gopherbot commented Feb 9, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 28, 2024

gopls/internal/analysis: add fill switch cases code action #476

gopls/internal/analysis: add fill switch cases code action #476

Conversation

martskins commented Feb 5, 2024 • edited Loading

gopherbot commented Feb 5, 2024

gopherbot commented Feb 5, 2024

gopherbot commented Feb 5, 2024

gopherbot commented Feb 5, 2024

gopherbot commented Feb 5, 2024

gopherbot commented Feb 6, 2024

gopherbot commented Feb 6, 2024

gopherbot commented Feb 6, 2024

gopherbot commented Feb 6, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 8, 2024

gopherbot commented Feb 9, 2024

gopherbot commented Feb 9, 2024

gopherbot commented Feb 9, 2024

gopherbot commented Feb 9, 2024

gopherbot commented Feb 9, 2024

gopherbot commented Feb 9, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 28, 2024

martskins commented Feb 5, 2024 •

edited

Loading