gopls/internal/util/frob: use reflect.Pointer

qiulaidongfeng · qiulaidongfeng · commit 8dd354efa88a · 2024-02-05T14:32:52.000+08:00
Complete a TODO.

Change-Id: If3095a035a163fdb893d93d65ba97808f77e1613
diff --git a/gopls/internal/util/frob/frob.go b/gopls/internal/util/frob/frob.go
@@ -93,7 +93,7 @@ func frobFor(t reflect.Type) *frob {
 
 		case reflect.Array,
 			reflect.Slice,
-			reflect.Ptr: // TODO(adonovan): after go1.18, use Pointer
+			reflect.Pointer:
 			fr.addElem(fr.t.Elem())
 
 		case reflect.Map:
@@ -214,7 +214,7 @@ func (fr *frob) encode(out *writer, v reflect.Value) {
 			}
 		}
 
-	case reflect.Ptr: // TODO(adonovan): after go1.18, use Pointer
+	case reflect.Pointer:
 		if v.IsNil() {
 			out.uint8(0)
 		} else {
@@ -341,7 +341,7 @@ func (fr *frob) decode(in *reader, addr reflect.Value) {
 			}
 		}
 
-	case reflect.Ptr: // TODO(adonovan): after go1.18, use Pointer
+	case reflect.Pointer:
 		isNil := in.uint8() == 0
 		if !isNil {
 			ptr := reflect.New(fr.elems[0].t)

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ func frobFor(t reflect.Type) *frob {`
`93`	`93`
`94`	`94`	`case reflect.Array,`
`95`	`95`	`reflect.Slice,`
`96`		`- reflect.Ptr: // TODO(adonovan): after go1.18, use Pointer`
	`96`	`+ reflect.Pointer:`
`97`	`97`	`fr.addElem(fr.t.Elem())`
`98`	`98`
`99`	`99`	`case reflect.Map:`
`@@ -214,7 +214,7 @@ func (fr frob) encode(out writer, v reflect.Value) {`
`214`	`214`	`}`
`215`	`215`	`}`
`216`	`216`
`217`		`- case reflect.Ptr: // TODO(adonovan): after go1.18, use Pointer`
	`217`	`+ case reflect.Pointer:`
`218`	`218`	`if v.IsNil() {`
`219`	`219`	`out.uint8(0)`
`220`	`220`	`} else {`
`@@ -341,7 +341,7 @@ func (fr frob) decode(in reader, addr reflect.Value) {`
`341`	`341`	`}`
`342`	`342`	`}`
`343`	`343`
`344`		`- case reflect.Ptr: // TODO(adonovan): after go1.18, use Pointer`
	`344`	`+ case reflect.Pointer:`
`345`	`345`	`isNil := in.uint8() == 0`
`346`	`346`	`if !isNil {`
`347`	`347`	`ptr := reflect.New(fr.elems[0].t)`