Skip to content

Commit

Permalink
gopls/doc: remove -tags=typeparams from generic build instructions
Browse files Browse the repository at this point in the history
As of CL 349949, this is not longer necessary.

Change-Id: Ie89a7771f5873c4acea54f4c2507b76ec9832706
Reviewed-on: https://go-review.googlesource.com/c/tools/+/350089
Trust: Robert Findley <rfindley@google.com>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
  • Loading branch information
findleyr committed Sep 15, 2021
1 parent 02e5238 commit 4ba3eff
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions gopls/doc/advanced.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,10 @@ $ gotip download
For building gopls with type parameter support, it is recommended that you
build gopls at tip. External APIs are under active development on the
Go `master` branch, so building gopls at tip minimizes the chances of
a build failure (though it is still possible). To get enhanced gopls features
for generic code, build gopls with the `typeparams` build constraint (though
this increases your chances of a build failure).
a build failure.

```
$ GO111MODULE=on gotip get -tags=typeparams golang.org/x/tools/gopls@master golang.org/x/tools@master
$ GO111MODULE=on gotip get golang.org/x/tools/gopls@master golang.org/x/tools@master
```

This will build a version of gopls that understands generic code. To actually
Expand Down

0 comments on commit 4ba3eff

Please sign in to comment.