cmd/callgraph: skip TestCallgraph on the windows-arm64-10 builder

Bryan C. Mills · Bryan Mills · commit 2cc183603134 · 2022-01-24T16:42:11.000Z
We don't know whether this failure is due to a Go bug or a platform bug, so we'll skip it on the one builder to reduce noise, but not the GOOS/GOARCH as a whole. If we do not observe failures on other windows/arm64 builders, we can perhaps chalk it up to a platform bug. If we do observe failures on other builders, then we'll have more data to investigate with. For golang/go#50706 Change-Id: I52511dd4a5cff80953823d9cf901975ff4657457 Reviewed-on: https://go-review.googlesource.com/c/tools/+/379734 Trust: Bryan Mills <bcmills@google.com> Reviewed-by: Daniel Martí <mvdan@mvdan.cc> Trust: Daniel Martí <mvdan@mvdan.cc>
diff --git a/cmd/callgraph/main_test.go b/cmd/callgraph/main_test.go
@@ -34,6 +34,10 @@ func init() {
 }
 
 func TestCallgraph(t *testing.T) {
+	if b := os.Getenv("GO_BUILDER_NAME"); b == "windows-arm64-10" {
+		t.Skipf("skipping due to suspected file corruption bug on %s builder (https://go.dev/issue/50706)", b)
+	}
+
 	testenv.NeedsTool(t, "go")
 
 	gopath, err := filepath.Abs("testdata")

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,10 @@ func init() {`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`func TestCallgraph(t *testing.T) {`
	`37`	`+ if b := os.Getenv("GO_BUILDER_NAME"); b == "windows-arm64-10" {`
	`38`	`+ t.Skipf("skipping due to suspected file corruption bug on %s builder (https://go.dev/issue/50706)", b)`
	`39`	`+ }`
	`40`	`+`
`37`	`41`	`testenv.NeedsTool(t, "go")`
`38`	`42`
`39`	`43`	`gopath, err := filepath.Abs("testdata")`