Skip to content

Commit 1edeebe

Browse files
committed
unix: mkall.sh: fail if docker build failed
When docker build fails, docker run (in my case podman) tries to find the generate:linux image from various mirrors, which is very confusing. We should error out if docker build fails. Change-Id: I4fd78e9fa339e03029b1bf003b3239ca23a7ed1b Reviewed-on: https://go-review.googlesource.com/c/sys/+/706916 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Kirill Kolyshkin <kolyshkin@gmail.com> Reviewed-by: Junyang Shao <shaojunyang@google.com> Reviewed-by: Sean Liao <sean@liao.dev> Reviewed-by: Carlos Amedee <carlos@golang.org>
1 parent ecada54 commit 1edeebe

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

unix/mkall.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ esac
4949
if [[ "$GOOS" = "linux" ]]; then
5050
# Use the Docker-based build system
5151
# Files generated through docker (use $cmd so you can Ctl-C the build or run)
52+
set -e
5253
$cmd docker build --tag generate:$GOOS $GOOS
5354
$cmd docker run --interactive --tty --volume $(cd -- "$(dirname -- "$0")/.." && pwd):/build generate:$GOOS
5455
exit

0 commit comments

Comments
 (0)