Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/sync
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.10.0
Choose a base ref
...
head repository: golang/sync
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.15.0
Choose a head ref
  • 8 commits
  • 7 files changed
  • 7 contributors

Commits on Jan 17, 2025

  1. sync/errgroup: improve documentation for semaphore limit behavior

    Updated the documentation for `SetLimit` and `Go` functions in the
    `errgroup` package. the note clarifies the behavior when the semaphore
    limit is set to zero, which could lead to a deadlock if not handled
    properly. the updated documentation warns users to set a positive
    semaphore limit to avoid blocking goroutines and potential deadlock
    
    this change improves the clarity of API and helps users understand how
    to properly use the semaphore limit to prevent issues in concurrent
    execution
    
    Change-Id: Ie62acc38ef804b3590c04bddba00a3cce21e8cef
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/642215
    Reviewed-by: Michael Knyszek <mknyszek@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    berbreik authored and gopherbot committed Jan 17, 2025
    Configuration menu
    Copy the full SHA
    fe3591b View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2025

  1. all: upgrade go directive to at least 1.23.0 [generated]

    By now Go 1.24.0 has been released, and Go 1.22 is no longer supported
    per the Go Release Policy (https://go.dev/doc/devel/release#policy).
    
    For golang/go#69095.
    
    [git-generate]
    (cd . && go get go@1.23.0 && go mod tidy && go fix ./... && go mod edit -toolchain=none)
    
    Change-Id: I7e3b1e073a0a64e82e2b9e49387d5da0afd9d58b
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/649835
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    gopherbot committed Feb 14, 2025
    Configuration menu
    Copy the full SHA
    960bf1f View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2025

  1. errgroup: drop support for Go versions before 1.20

    Change-Id: I7de5dfae21c4ffe31d6c16e3df0fed3e2269cb16
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/654421
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Commit-Queue: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    ianlancetaylor authored and gopherbot committed Mar 4, 2025
    Configuration menu
    Copy the full SHA
    b637f27 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2025

  1. errgroup: document calling Go before Wait

    Fixes golang/go#70284
    
    Change-Id: I31d60ea182226c032b0ffbddcbb5b53675dfd5e6
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/660075
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Alan Donovan <adonovan@google.com>
    Auto-Submit: Damien Neil <dneil@google.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    seankhliao authored and gopherbot committed Apr 2, 2025
    Configuration menu
    Copy the full SHA
    396f3a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2025

  1. errgroup: propagate panic and Goexit through Wait

    Recovered panic values are wrapped and saved in Group.
    Goexits are detected by a sentinel value set after the given function
    returns normally. Wait propagates the first instance of a panic or
    Goexit.
    
    According to the runtime.Goexit after the code will not be executed,
    with a bool, if f not call runtime.Goexit, is true,
    determine whether to propagate runtime.Goexit.
    
    Fixes golang/go#53757
    
    Change-Id: Ic6426fc014fd1c4368ebaceef5b0d6163770a099
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/644575
    Reviewed-by: Sean Liao <sean@liao.dev>
    Auto-Submit: Alan Donovan <adonovan@google.com>
    Commit-Queue: Alan Donovan <adonovan@google.com>
    Reviewed-by: Alan Donovan <adonovan@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    qiulaidongfeng authored and gopherbot committed Apr 7, 2025
    Configuration menu
    Copy the full SHA
    506c70f View commit details
    Browse the repository at this point in the history

Commits on May 14, 2025

  1. sync/errgroup: PanicError.Error print stack trace

    Because it is useful to print the stack
    when a nil pointer dereference occurs.
    
    Fixes golang/go#73710
    
    Change-Id: I106ea0bdd70c2a293f5ea889edef9b5ba9db2fbd
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/672635
    Reviewed-by: Damien Neil <dneil@google.com>
    Auto-Submit: Damien Neil <dneil@google.com>
    Auto-Submit: Alan Donovan <adonovan@google.com>
    Reviewed-by: Alan Donovan <adonovan@google.com>
    TryBot-Bypass: Damien Neil <dneil@google.com>
    qiulaidongfeng authored and gopherbot committed May 14, 2025
    Configuration menu
    Copy the full SHA
    d1ac909 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2025

  1. all: replace deprecated ioutil

    Change-Id: I1beb9f5e759127a48c4e5ea0613a5a466886b7c5
    GitHub-Last-Rev: 58038b6
    GitHub-Pull-Request: #28
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/674815
    Reviewed-by: Alan Donovan <adonovan@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Sean Liao <sean@liao.dev>
    Auto-Submit: Alan Donovan <adonovan@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    12ya authored and gopherbot committed May 24, 2025
    Configuration menu
    Copy the full SHA
    1869c69 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2025

  1. errgroup: remove duplicated comment

    Change-Id: I5cdcc5034ccd87b939a406693e97485553ab60fa
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/676715
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Alan Donovan <adonovan@google.com>
    Auto-Submit: Alan Donovan <adonovan@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    xieyuschen authored and gopherbot committed May 28, 2025
    Configuration menu
    Copy the full SHA
    8a14946 View commit details
    Browse the repository at this point in the history
Loading