Skip to content

Commit ecfafd6

Browse files
zcheeJay Conrod
authored andcommitted
semver: remove unused err field
The err field is assigned in the parse function but never used on another function. Change-Id: I1ea5fa922776c2c83f5269724f856e8d667f43b4 Reviewed-on: https://go-review.googlesource.com/c/mod/+/353749 Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com> Trust: Jay Conrod <jayconrod@google.com> Trust: Michael Knyszek <mknyszek@google.com>
1 parent dd30a60 commit ecfafd6

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

semver/semver.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ type parsed struct {
3232
short string
3333
prerelease string
3434
build string
35-
err string
3635
}
3736

3837
// IsValid reports whether v is a valid semantic version string.
@@ -172,12 +171,10 @@ func Sort(list []string) {
172171

173172
func parse(v string) (p parsed, ok bool) {
174173
if v == "" || v[0] != 'v' {
175-
p.err = "missing v prefix"
176174
return
177175
}
178176
p.major, v, ok = parseInt(v[1:])
179177
if !ok {
180-
p.err = "bad major version"
181178
return
182179
}
183180
if v == "" {
@@ -187,13 +184,11 @@ func parse(v string) (p parsed, ok bool) {
187184
return
188185
}
189186
if v[0] != '.' {
190-
p.err = "bad minor prefix"
191187
ok = false
192188
return
193189
}
194190
p.minor, v, ok = parseInt(v[1:])
195191
if !ok {
196-
p.err = "bad minor version"
197192
return
198193
}
199194
if v == "" {
@@ -202,31 +197,26 @@ func parse(v string) (p parsed, ok bool) {
202197
return
203198
}
204199
if v[0] != '.' {
205-
p.err = "bad patch prefix"
206200
ok = false
207201
return
208202
}
209203
p.patch, v, ok = parseInt(v[1:])
210204
if !ok {
211-
p.err = "bad patch version"
212205
return
213206
}
214207
if len(v) > 0 && v[0] == '-' {
215208
p.prerelease, v, ok = parsePrerelease(v)
216209
if !ok {
217-
p.err = "bad prerelease"
218210
return
219211
}
220212
}
221213
if len(v) > 0 && v[0] == '+' {
222214
p.build, v, ok = parseBuild(v)
223215
if !ok {
224-
p.err = "bad build"
225216
return
226217
}
227218
}
228219
if v != "" {
229-
p.err = "junk on end"
230220
ok = false
231221
return
232222
}

0 commit comments

Comments
 (0)