This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
mockgen: don't ignore stdout.Write error #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blico Could you open up a corresponding issue for discussion? |
codyoss
approved these changes
Mar 13, 2020
|
@blico Thanks for the contribution. 🎆 Do you need a proper release for this, or do you pin to sha in your build system? |
|
@codyoss Thanks for the quick response! We use go modules, so although a proper release is not required, it would be preferred. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #411
I am running into an issue when using
mockgen's-prog_onlyflag where an empty file is returned, but the program still exits with 0. I suspect this is becauseos.Stdout.Write's error is being ignored.Submitter Checklist
Reviewer Notes
Release Notes
n/a