Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Installing mockgen does not get added to path #490

Closed
pickfire opened this issue Oct 6, 2020 · 2 comments · Fixed by #534
Closed

Installing mockgen does not get added to path #490

pickfire opened this issue Oct 6, 2020 · 2 comments · Fixed by #534

Comments

@pickfire
Copy link

pickfire commented Oct 6, 2020

Actual behavior Mockgen was added in ~/src/go/bin/mockgen by installing it with GO111MODULE=on go get github.com/golang/mock/mockgen@v1.4.4, but no warnings were given that ~/src/go/bin is not part of PATH environment variables.

Expected behavior A clear and concise warning should be given to users when installing.

To Reproduce Steps to reproduce the behavior

  1. GO111MODULE=on go get github.com/golang/mock/mockgen@v1.4.4

Additional Information

  • gomock mode (reflect or source):
  • gomock version or git ref: v1.4.4
  • golang version: go version go1.15.2 linux/amd64

Triage Notes for the Maintainers

@codyoss
Copy link
Member

codyoss commented Oct 6, 2020

Hey,

All go binaries are by default installed to $GOPATH/bin. It is common practice to add this location to your PATH. It is the responsibility of the user to do so.

There is no warning we could provide in the tooling, but we could add a note to our README. Feel free to open a PR if you are willing.

@montogeek
Copy link

There is no warning we could provide in the tooling,

Why?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants