From 7b53c4de32f63187e7047cb19e75c2ca4dd7d5cc Mon Sep 17 00:00:00 2001
From: Anton Carlos <antonstraeter@gmail.com>
Date: Tue, 18 Aug 2020 16:16:35 +0200
Subject: [PATCH] check error for os.Setenv in parse_test.go (#472)

Add some missing error checks for the os.SetEnv()
method in mockgen/parse_test.go.

Fixes: #473
---
 mockgen/parse_test.go | 28 +++++++++++++++++++++++-----
 1 file changed, 23 insertions(+), 5 deletions(-)

diff --git a/mockgen/parse_test.go b/mockgen/parse_test.go
index 28fb5d57..b0cdbb13 100644
--- a/mockgen/parse_test.go
+++ b/mockgen/parse_test.go
@@ -167,7 +167,9 @@ func TestParsePackageImport(t *testing.T) {
 	} {
 		t.Run(testCase.name, func(t *testing.T) {
 			for key, value := range testCase.envs {
-				os.Setenv(key, value)
+				if err := os.Setenv(key, value); err != nil {
+					t.Fatalf("unable to set environment variable %q to %q: %v", key, value, err)
+				}
 			}
 			pkgPath, err := parsePackageImport(filepath.Clean(testCase.dir))
 			if err != testCase.err {
@@ -195,8 +197,16 @@ func TestParsePackageImport_FallbackGoPath(t *testing.T) {
 	if err != nil {
 		t.Error(err)
 	}
-	os.Setenv("GOPATH", goPath)
-	os.Setenv("GO111MODULE", "on")
+	key := "GOPATH"
+	value := goPath
+	if err := os.Setenv(key, value); err != nil {
+		t.Fatalf("unable to set environment variable %q to %q: %v", key, value, err)
+	}
+	key = "GO111MODULE"
+	value = "on"
+	if err := os.Setenv(key, value); err != nil {
+		t.Fatalf("unable to set environment variable %q to %q: %v", key, value, err)
+	}
 	pkgPath, err := parsePackageImport(srcDir)
 	expected := "example.com/foo"
 	if pkgPath != expected {
@@ -237,8 +247,16 @@ func TestParsePackageImport_FallbackMultiGoPath(t *testing.T) {
 	}()
 
 	goPaths := strings.Join(goPathList, string(os.PathListSeparator))
-	os.Setenv("GOPATH", goPaths)
-	os.Setenv("GO111MODULE", "on")
+	key := "GOPATH"
+	value := goPaths
+	if err := os.Setenv(key, value); err != nil {
+		t.Fatalf("unable to set environment variable %q to %q: %v", key, value, err)
+	}
+	key = "GO111MODULE"
+	value = "on"
+	if err := os.Setenv(key, value); err != nil {
+		t.Fatalf("unable to set environment variable %q to %q: %v", key, value, err)
+	}
 	pkgPath, err := parsePackageImport(srcDir)
 	expected := "example.com/foo"
 	if pkgPath != expected {