Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: support millisecond timestamp resolution #60246

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

log: support millisecond timestamp resolution #60246

wants to merge 1 commit into from
+14 −3

Conversation

mitar
Copy link
Contributor

@mitar mitar commented May 16, 2023 •
edited
Loading

Existing implementation had only microsecond or second resolution, but microsecond resolution could be seen as too precise (access to logs could be used for side channel attacks) while second resolution is not precise enough.

This adds Lmilliseconds flag.

Fixes #60249

@gopherbot
Copy link
Contributor

This PR (HEAD: 520c71f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/495298 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Hold+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/495298.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Mitar:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/495298.
After addressing review feedback, remember to publish your drafts!

@mitar mitar mentioned this pull request May 17, 2023
Open
@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/495298.
After addressing review feedback, remember to publish your drafts!

@mitar
log: support millisecond timestamp resolution
e57d2bc 
Existing implementation had only microsecond or second resolution,
but microsecond resolution could be seen as too precise (access to
logs could be used for side channel attacks) while second resolution
is not precise enough.

This adds Lmilliseconds flag.

Fixes golang#60249
@gopherbot
Copy link
Contributor

This PR (HEAD: e57d2bc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/495298 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Mitar:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/495298.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proposal: log: support millisecond timestamp resolution
2 participants
@mitar @gopherbot