Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: allow generate to skip missing files #45642

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cmd/go: allow generate to skip missing files #45642

wants to merge 1 commit into from
+40 −0

Conversation

tie
Copy link
Contributor

@tie tie commented Apr 20, 2021 •
edited
Loading

This change allows go generate to process packages where files may
disappear during code generation. See also #36422.

Updates #36068

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Apr 20, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: d13404b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/311531 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/311531.
After addressing review feedback, remember to publish your drafts!

@tie
cmd/go: allow generate to skip missing files
4ec27c1 
This change allows go generate to process packages where files may
disappear during code generation. See also golang#36422.

Updates golang#36068
@gopherbot
Copy link
Contributor

This PR (HEAD: 4ec27c1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/311531 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ivan Trubach:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/311531.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ivan Trubach:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/311531.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/311531.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/311531.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ivan Trubach:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/311531.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ivan Trubach:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/311531.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/311531.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tie @gopherbot